[jira] [Comment Edited] (SOLR-12625) Combine SolrDocumentFetcher and RetrieveFieldsOptimizer

["David Smiley (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16575213#comment-16575213 ] 

David Smiley edited comment on SOLR-12625 at 8/9/18 5:54 PM:
-------------------------------------------------------------

{quote}1> making the code convert to native types and have a getValAsString() method that at least conceals the above ugliness when the user doesn't care?
{quote}
+0... maybe warn that the native type might actually be a number or date, therefore this method might do a conversion.

Can you give a couple examples of what the caller is going to do with this – why they want specifically a String?


was (Author: dsmiley):
{quote}1> making the code convert to native types and have a getValAsString() method that at least conceals the above ugliness when the user doesn't care?
{quote}
+1... maybe warn that the native type might actually be a number or date, therefore this method might do a conversion.

> Combine SolrDocumentFetcher and RetrieveFieldsOptimizer
> -------------------------------------------------------
>
>                 Key: SOLR-12625
>                 URL: https://issues.apache.org/jira/browse/SOLR-12625
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Major
>         Attachments: SOLR-12625.patch, SOLR-12625.patch
>
>
> We have SolrDocumentFetcher and RetrieveFieldsOptimizer. The
> relationship between the two is unclear at first glance. Using
> SolrDocumentFetcher by itself is (or can be) inefficient.
> WDYT about combining the two? Is there a good reason you would want to
> use SolrDocumentFetcher _instead_ of RetrieveFieldsOptimizer?
> Ideally I'd want to be able to write code like:
> solrDocumentFetcher.fillDocValuesMostEfficiently
> That created an optimizer and "did the right thing".
> Assigning to myself to keep track, but if anyone feels motivated feel free to take it over.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org