You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by on...@apache.org on 2016/09/11 03:37:57 UTC
svn commit: r1760219 - in /poi/trunk/src:
java/org/apache/poi/ss/usermodel/DataFormatter.java
testcases/org/apache/poi/ss/usermodel/TestDataFormatter.java
Author: onealj
Date: Sun Sep 11 03:37:56 2016
New Revision: 1760219
URL: http://svn.apache.org/viewvc?rev=1760219&view=rev
Log:
bug 60025: DataFormatter should print booleans as TRUE/FALSE, not true/false
Modified:
poi/trunk/src/java/org/apache/poi/ss/usermodel/DataFormatter.java
poi/trunk/src/testcases/org/apache/poi/ss/usermodel/TestDataFormatter.java
Modified: poi/trunk/src/java/org/apache/poi/ss/usermodel/DataFormatter.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ss/usermodel/DataFormatter.java?rev=1760219&r1=1760218&r2=1760219&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/ss/usermodel/DataFormatter.java (original)
+++ poi/trunk/src/java/org/apache/poi/ss/usermodel/DataFormatter.java Sun Sep 11 03:37:56 2016
@@ -895,7 +895,7 @@ public class DataFormatter implements Ob
return cell.getRichStringCellValue().getString();
case BOOLEAN :
- return String.valueOf(cell.getBooleanCellValue());
+ return cell.getBooleanCellValue() ? "TRUE" : "FALSE";
case BLANK :
return "";
case ERROR:
Modified: poi/trunk/src/testcases/org/apache/poi/ss/usermodel/TestDataFormatter.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/usermodel/TestDataFormatter.java?rev=1760219&r1=1760218&r2=1760219&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/ss/usermodel/TestDataFormatter.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/ss/usermodel/TestDataFormatter.java Sun Sep 11 03:37:56 2016
@@ -597,6 +597,27 @@ public class TestDataFormatter {
}
}
+ @Test
+ public void testBoolean() throws IOException {
+ DataFormatter formatter = new DataFormatter();
+
+ // Create a spreadsheet with some TRUE/FALSE boolean values in it
+ Workbook wb = new HSSFWorkbook();
+ try {
+ Sheet s = wb.createSheet();
+ Row r = s.createRow(0);
+ Cell c = r.createCell(0);
+
+ c.setCellValue(true);
+ assertEquals("TRUE", formatter.formatCellValue(c));
+
+ c.setCellValue(false);
+ assertEquals("FALSE", formatter.formatCellValue(c));
+ } finally {
+ wb.close();
+ }
+ }
+
/**
* While we don't currently support using a locale code at
* the start of a format string to format it differently, we
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org