You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "linguini1 (via GitHub)" <gi...@apache.org> on 2025/07/24 19:30:19 UTC
[PR] drivers/sensors/l86xxx: Fix driver registration crashes [nuttx]
linguini1 opened a new pull request, #16764:
URL: https://github.com/apache/nuttx/pull/16764
## Summary
Sometimes this driver will boot when the serial port is of the wrong baud rate, and it cannot set the correct baud rate or verify communication. This commit prevents registration if any settings fail to be set, and also prevents the kernel thread from setting the L86 to enabled (this is done only by the uORB upper half).
## Impact
Impacts only this driver. Removes possibility for kernel crash, instead fails gracefully.
## Testing
Prior to this change, a misconfiguration of the serial baud rate would result in a kernel crash.
Now this is the behaviour:
```console
l86xxx_register: Waiting for GNSS to start...
send_command: Sending command: $PMTK251,9600 to L86
send_command: Sending command: $PMTK220,1000 to L86
send_command: Waiting for ACK from L86...
send_command: Did not get ACK!
l86xxx_register: Couldn't set position fix interval, -5
Failed to register L86-M33: -5
NuttShell (NSH) NuttX-12.8.0
nsh>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] drivers/sensors/l86xxx: Fix driver registration crashes [nuttx]
Posted by "linguini1 (via GitHub)" <gi...@apache.org>.
linguini1 commented on PR #16764:
URL: https://github.com/apache/nuttx/pull/16764#issuecomment-3117856774
> @linguini1 maybe you can use termios to change the baudrate dynamically or try different baudrates to get communication with the GPS working
That would be interesting!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] drivers/sensors/l86xxx: Fix driver registration crashes [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #16764:
URL: https://github.com/apache/nuttx/pull/16764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] drivers/sensors/l86xxx: Fix driver registration crashes [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #16764:
URL: https://github.com/apache/nuttx/pull/16764#issuecomment-3117863580
You can use apps/examples/termios/termios_main.c as reference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] drivers/sensors/l86xxx: Fix driver registration crashes [nuttx]
Posted by "linguini1 (via GitHub)" <gi...@apache.org>.
linguini1 commented on PR #16764:
URL: https://github.com/apache/nuttx/pull/16764#issuecomment-3117807710
Please don't merge the draft PRs unless I mark them as ready for review! Was trying to do some more testing to make this a little more reliable, I will open another PR when that is ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] drivers/sensors/l86xxx: Fix driver registration crashes [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #16764:
URL: https://github.com/apache/nuttx/pull/16764#issuecomment-3117815005
@linguini1 maybe you can use termios to change the baudrate dynamically or try different baudrates to get communication with the GPS working
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org