You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Eric Yang (JIRA)" <ji...@apache.org> on 2009/03/05 20:23:56 UTC
[jira] Created: (HADOOP-5411) Use StringBuffer for building Chukwa
Chart object
Use StringBuffer for building Chukwa Chart object
-------------------------------------------------
Key: HADOOP-5411
URL: https://issues.apache.org/jira/browse/HADOOP-5411
Project: Hadoop Core
Issue Type: Improvement
Components: contrib/chukwa
Environment: Redhat 5.1, Java 6
Reporter: Eric Yang
Assignee: Eric Yang
Priority: Minor
The Chukwa Chart object is using String to build the ajax chart data. This should be converted to use StringBuffer to speed up efficiency.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5411) Use StringBuffer for building Chukwa
Chart object
Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Yang updated HADOOP-5411:
------------------------------
Attachment: HADOOP-5411.patch
Converted Chart object from String to StringBuilder.
> Use StringBuffer for building Chukwa Chart object
> -------------------------------------------------
>
> Key: HADOOP-5411
> URL: https://issues.apache.org/jira/browse/HADOOP-5411
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/chukwa
> Environment: Redhat 5.1, Java 6
> Reporter: Eric Yang
> Assignee: Eric Yang
> Priority: Minor
> Attachments: HADOOP-5411.patch
>
>
> The Chukwa Chart object is using String to build the ajax chart data. This should be converted to use StringBuffer to speed up efficiency.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (HADOOP-5411) Use StringBuffer for
building Chukwa Chart object
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679411#action_12679411 ]
szetszwo edited comment on HADOOP-5411 at 3/5/09 3:00 PM:
------------------------------------------------------------------------
Consider using StringBuilder if you don't need synchronization guarantee.
was (Author: szetszwo):
Consider use StringBuilder if you don't need no synchronization guarantee.
> Use StringBuffer for building Chukwa Chart object
> -------------------------------------------------
>
> Key: HADOOP-5411
> URL: https://issues.apache.org/jira/browse/HADOOP-5411
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/chukwa
> Environment: Redhat 5.1, Java 6
> Reporter: Eric Yang
> Assignee: Eric Yang
> Priority: Minor
>
> The Chukwa Chart object is using String to build the ajax chart data. This should be converted to use StringBuffer to speed up efficiency.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5411) Use StringBuffer for building Chukwa
Chart object
Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Yang updated HADOOP-5411:
------------------------------
Resolution: Fixed
Release Note:
What is new in HADOOP-5411:
- Converted from String to StringBuilder for Chart class.
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
> Use StringBuffer for building Chukwa Chart object
> -------------------------------------------------
>
> Key: HADOOP-5411
> URL: https://issues.apache.org/jira/browse/HADOOP-5411
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/chukwa
> Environment: Redhat 5.1, Java 6
> Reporter: Eric Yang
> Assignee: Eric Yang
> Priority: Minor
> Attachments: HADOOP-5411.patch
>
>
> The Chukwa Chart object is using String to build the ajax chart data. This should be converted to use StringBuffer to speed up efficiency.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5411) Use StringBuffer for building
Chukwa Chart object
Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679453#action_12679453 ]
Eric Yang commented on HADOOP-5411:
-----------------------------------
Agree, I don't need synchronization. Switching to StringBuilder. Thanks
> Use StringBuffer for building Chukwa Chart object
> -------------------------------------------------
>
> Key: HADOOP-5411
> URL: https://issues.apache.org/jira/browse/HADOOP-5411
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/chukwa
> Environment: Redhat 5.1, Java 6
> Reporter: Eric Yang
> Assignee: Eric Yang
> Priority: Minor
>
> The Chukwa Chart object is using String to build the ajax chart data. This should be converted to use StringBuffer to speed up efficiency.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5411) Use StringBuffer for building
Chukwa Chart object
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681781#action_12681781 ]
Hudson commented on HADOOP-5411:
--------------------------------
Integrated in Hadoop-trunk #778 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/778/])
> Use StringBuffer for building Chukwa Chart object
> -------------------------------------------------
>
> Key: HADOOP-5411
> URL: https://issues.apache.org/jira/browse/HADOOP-5411
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/chukwa
> Environment: Redhat 5.1, Java 6
> Reporter: Eric Yang
> Assignee: Eric Yang
> Priority: Minor
> Attachments: HADOOP-5411.patch
>
>
> The Chukwa Chart object is using String to build the ajax chart data. This should be converted to use StringBuffer to speed up efficiency.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5411) Use StringBuffer for building
Chukwa Chart object
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680190#action_12680190 ]
Hadoop QA commented on HADOOP-5411:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12401580/HADOOP-5411.patch
against trunk revision 751463.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 2 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/35/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/35/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/35/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/35/console
This message is automatically generated.
> Use StringBuffer for building Chukwa Chart object
> -------------------------------------------------
>
> Key: HADOOP-5411
> URL: https://issues.apache.org/jira/browse/HADOOP-5411
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/chukwa
> Environment: Redhat 5.1, Java 6
> Reporter: Eric Yang
> Assignee: Eric Yang
> Priority: Minor
> Attachments: HADOOP-5411.patch
>
>
> The Chukwa Chart object is using String to build the ajax chart data. This should be converted to use StringBuffer to speed up efficiency.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5411) Use StringBuffer for building
Chukwa Chart object
Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680192#action_12680192 ]
Eric Yang commented on HADOOP-5411:
-----------------------------------
The mapred test case fail is not related to this patch.
> Use StringBuffer for building Chukwa Chart object
> -------------------------------------------------
>
> Key: HADOOP-5411
> URL: https://issues.apache.org/jira/browse/HADOOP-5411
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/chukwa
> Environment: Redhat 5.1, Java 6
> Reporter: Eric Yang
> Assignee: Eric Yang
> Priority: Minor
> Attachments: HADOOP-5411.patch
>
>
> The Chukwa Chart object is using String to build the ajax chart data. This should be converted to use StringBuffer to speed up efficiency.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5411) Use StringBuffer for building
Chukwa Chart object
Posted by "Ari Rabkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679763#action_12679763 ]
Ari Rabkin commented on HADOOP-5411:
------------------------------------
Looks ok. +1
> Use StringBuffer for building Chukwa Chart object
> -------------------------------------------------
>
> Key: HADOOP-5411
> URL: https://issues.apache.org/jira/browse/HADOOP-5411
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/chukwa
> Environment: Redhat 5.1, Java 6
> Reporter: Eric Yang
> Assignee: Eric Yang
> Priority: Minor
> Attachments: HADOOP-5411.patch
>
>
> The Chukwa Chart object is using String to build the ajax chart data. This should be converted to use StringBuffer to speed up efficiency.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5411) Use StringBuffer for building
Chukwa Chart object
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679411#action_12679411 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-5411:
------------------------------------------------
Consider use StringBuilder if you don't need no synchronization guarantee.
> Use StringBuffer for building Chukwa Chart object
> -------------------------------------------------
>
> Key: HADOOP-5411
> URL: https://issues.apache.org/jira/browse/HADOOP-5411
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/chukwa
> Environment: Redhat 5.1, Java 6
> Reporter: Eric Yang
> Assignee: Eric Yang
> Priority: Minor
>
> The Chukwa Chart object is using String to build the ajax chart data. This should be converted to use StringBuffer to speed up efficiency.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5411) Use StringBuffer for building Chukwa
Chart object
Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Yang updated HADOOP-5411:
------------------------------
Status: Patch Available (was: Open)
Converted from String to StringBuilder for Chart class.
> Use StringBuffer for building Chukwa Chart object
> -------------------------------------------------
>
> Key: HADOOP-5411
> URL: https://issues.apache.org/jira/browse/HADOOP-5411
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/chukwa
> Environment: Redhat 5.1, Java 6
> Reporter: Eric Yang
> Assignee: Eric Yang
> Priority: Minor
> Attachments: HADOOP-5411.patch
>
>
> The Chukwa Chart object is using String to build the ajax chart data. This should be converted to use StringBuffer to speed up efficiency.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.