[GitHub] [dubbo] guohao commented on a change in pull request #8705: [3.0-Triple] fix tri stream method can not find methodDescriptor

[GitBox <gi...@apache.org>]

guohao commented on a change in pull request #8705:
URL: https://github.com/apache/dubbo/pull/8705#discussion_r703174293



##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleClientHandler.java
##########
@@ -74,12 +74,12 @@ private void writeRequest(ChannelHandlerContext ctx, final Request req, final Ch
         final URL url = inv.getInvoker().getUrl();
         ConsumerModel consumerModel = (ConsumerModel) url.getServiceModel();
 
-        MethodDescriptor methodDescriptor = consumerModel.getServiceModel().getMethod(inv.getMethodName(), inv.getParameterTypes());
-        String serviceKey = url.getServiceKey();
-        // If it is InstanceAddressURL, the serviceKey may not be obtained.
-        if (null == serviceKey) {
-            serviceKey = inv.getTargetServiceUniqueName();
-        }
+        MethodDescriptor methodDescriptor = inv.getMethodDescriptor();
+        // String serviceKey = url.getServiceKey();

Review comment:
       Remove this ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org