You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Herve Boutemy (Jira)" <ji...@apache.org> on 2022/04/02 13:01:00 UTC
[jira] [Comment Edited] (MSHADE-417) Nul bytes appended to small files by maven-shade-plugin
[ https://issues.apache.org/jira/browse/MSHADE-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515840#comment-17515840 ]
Herve Boutemy edited comment on MSHADE-417 at 4/2/22 1:00 PM:
--------------------------------------------------------------
https://github.com/apache/maven-shade-plugin/commit/c798d01138e9fecdd6422a2a8acce22ca8987924 is the first bad commit
{noformat}
commit c798d01138e9fecdd6422a2a8acce22ca8987924
Author: jenrryyou <fl...@qq.com>
Date: Sun Nov 22 23:17:56 2020 +0800
[MSHADE-378] Shade plugin changes the compression level of nested jar… (#73)
* [MSHADE-378] Shade plugin changes the compression level of nested jar entries
* [MSHADE-378] Shade plugin changes the compression level of nested jar entries
Co-authored-by: shaoyao <je...@alibaba-inc.com>
.../apache/maven/plugins/shade/DefaultShader.java | 107 +++++++++++++++++++--
.../maven/plugins/shade/DefaultShaderTest.java | 67 +++++++++++++
2 files changed, 165 insertions(+), 9 deletions(-)
{noformat}
was (Author: michael-o):
{noformat}
c798d01138e9fecdd6422a2a8acce22ca8987924 is the first bad commit
commit c798d01138e9fecdd6422a2a8acce22ca8987924
Author: jenrryyou <fl...@qq.com>
Date: Sun Nov 22 23:17:56 2020 +0800
[MSHADE-378] Shade plugin changes the compression level of nested jar… (#73)
* [MSHADE-378] Shade plugin changes the compression level of nested jar entries
* [MSHADE-378] Shade plugin changes the compression level of nested jar entries
Co-authored-by: shaoyao <je...@alibaba-inc.com>
.../apache/maven/plugins/shade/DefaultShader.java | 107 +++++++++++++++++++--
.../maven/plugins/shade/DefaultShaderTest.java | 67 +++++++++++++
2 files changed, 165 insertions(+), 9 deletions(-)
{noformat}
> Nul bytes appended to small files by maven-shade-plugin
> -------------------------------------------------------
>
> Key: MSHADE-417
> URL: https://issues.apache.org/jira/browse/MSHADE-417
> Project: Maven Shade Plugin
> Issue Type: Bug
> Affects Versions: 3.3.0
> Reporter: Max Zerzouri
> Priority: Major
> Attachments: original-shadetest-0.0.0.jar, pom.xml, shadetest-0.0.0.jar, test.txt
>
>
> Version 3.3.0 of maven shade plugin seems to append "\x00" bytes to a file if it's less than 4 bytes:
> {code:sh}
> $ echo -n a > src/main/resources/test.txt
> $ mvn clean install
> ...
> $ bsdtar -xOf target/original-shadetest-0.0.0.jar test.txt | xxd
> 00000000: 61 a
> $ bsdtar -xOf target/shadetest-0.0.0.jar test.txt | xxd
> 00000000: 6100 0000 a...
> {code}
> I've attached a basic {{pom.xml}} that triggers this. This doesn't occur in the previous version, 3.2.4.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)