You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tamas Mate (Code Review)" <ge...@cloudera.org> on 2023/01/03 20:33:18 UTC

[Impala-ASF-CR] IMPALA-11819: [DOCS] Add Iceberg LOAD DATA information

Tamas Mate has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19396


Change subject: IMPALA-11819: [DOCS] Add Iceberg LOAD DATA information
......................................................................

IMPALA-11819: [DOCS] Add Iceberg LOAD DATA information

This commit adds information on how LOAD DATA statement can be used with
Iceberg tables.

Testing:
 - Built docs locally

Change-Id: Iec242781a4551aa04e4e920e3f3a1010c7ab808e
---
M docs/shared/impala_common.xml
M docs/topics/impala_iceberg.xml
M docs/topics/impala_load_data.xml
3 files changed, 30 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/19396/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec242781a4551aa04e4e920e3f3a1010c7ab808e
Gerrit-Change-Number: 19396
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11819: [DOCS] Add Iceberg LOAD DATA information

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19396 )

Change subject: IMPALA-11819: [DOCS] Add Iceberg LOAD DATA information
......................................................................


Patch Set 1: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/686/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/19396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec242781a4551aa04e4e920e3f3a1010c7ab808e
Gerrit-Change-Number: 19396
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Jan 2023 20:41:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11819: [DOCS] Add Iceberg LOAD DATA information

Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19396 )

Change subject: IMPALA-11819: [DOCS] Add Iceberg LOAD DATA information
......................................................................

IMPALA-11819: [DOCS] Add Iceberg LOAD DATA information

This commit adds information on how LOAD DATA statement can be used with
Iceberg tables.

Testing:
 - Built docs locally

Change-Id: Iec242781a4551aa04e4e920e3f3a1010c7ab808e
Reviewed-on: http://gerrit.cloudera.org:8080/19396
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Gergely Fürnstáhl <gf...@cloudera.com>
Reviewed-by: Noemi Pap-Takacs <np...@cloudera.com>
Reviewed-by: Tamas Mate <tm...@apache.org>
---
M docs/shared/impala_common.xml
M docs/topics/impala_iceberg.xml
M docs/topics/impala_load_data.xml
3 files changed, 30 insertions(+), 0 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Gergely Fürnstáhl: Looks good to me, but someone else must approve
  Noemi Pap-Takacs: Looks good to me, but someone else must approve
  Tamas Mate: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/19396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iec242781a4551aa04e4e920e3f3a1010c7ab808e
Gerrit-Change-Number: 19396
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11819: [DOCS] Add Iceberg LOAD DATA information

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19396 )

Change subject: IMPALA-11819: [DOCS] Add Iceberg LOAD DATA information
......................................................................


Patch Set 1:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/686/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/19396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec242781a4551aa04e4e920e3f3a1010c7ab808e
Gerrit-Change-Number: 19396
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Jan 2023 20:33:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11819: [DOCS] Add Iceberg LOAD DATA information

Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19396 )

Change subject: IMPALA-11819: [DOCS] Add Iceberg LOAD DATA information
......................................................................


Patch Set 2: Code-Review+2

Thank you for the reviews!


-- 
To view, visit http://gerrit.cloudera.org:8080/19396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec242781a4551aa04e4e920e3f3a1010c7ab808e
Gerrit-Change-Number: 19396
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Jan 2023 12:04:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11819: [DOCS] Add Iceberg LOAD DATA information

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19396 )

Change subject: IMPALA-11819: [DOCS] Add Iceberg LOAD DATA information
......................................................................


Patch Set 2: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/689/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/19396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec242781a4551aa04e4e920e3f3a1010c7ab808e
Gerrit-Change-Number: 19396
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sun, 08 Jan 2023 10:36:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11819: [DOCS] Add Iceberg LOAD DATA information

Posted by "Gergely Fürnstáhl (Code Review)" <ge...@cloudera.org>.
Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/19396 )

Change subject: IMPALA-11819: [DOCS] Add Iceberg LOAD DATA information
......................................................................


Patch Set 1:

(1 comment)

Added a few nitpicks, feel free to fight back if you disagree, I am far from an expert in English :)

http://gerrit.cloudera.org:8080/#/c/19396/1/docs/topics/impala_iceberg.xml
File docs/topics/impala_iceberg.xml:

http://gerrit.cloudera.org:8080/#/c/19396/1/docs/topics/impala_iceberg.xml@451
PS1, Line 451: through subsequently
I think "through" is only used in it's literal meaning, when you physically go through the door.

I would use "via", or maybe "by".

"subsequently" is a bit weird as well, it suggests that we execute the statements after the data is inserted, but that is not what happening. If you wanted to express that we execute several (sub) statements one after another to achieve the data insertion, then it should be "sequentially"



-- 
To view, visit http://gerrit.cloudera.org:8080/19396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec242781a4551aa04e4e920e3f3a1010c7ab808e
Gerrit-Change-Number: 19396
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 04 Jan 2023 09:57:34 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11819: [DOCS] Add Iceberg LOAD DATA information

Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19396 )

Change subject: IMPALA-11819: [DOCS] Add Iceberg LOAD DATA information
......................................................................

IMPALA-11819: [DOCS] Add Iceberg LOAD DATA information

This commit adds information on how LOAD DATA statement can be used with
Iceberg tables.

Testing:
 - Built docs locally

Change-Id: Iec242781a4551aa04e4e920e3f3a1010c7ab808e
---
M docs/shared/impala_common.xml
M docs/topics/impala_iceberg.xml
M docs/topics/impala_load_data.xml
3 files changed, 30 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/19396/2
-- 
To view, visit http://gerrit.cloudera.org:8080/19396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iec242781a4551aa04e4e920e3f3a1010c7ab808e
Gerrit-Change-Number: 19396
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11819: [DOCS] Add Iceberg LOAD DATA information

Posted by "Gergely Fürnstáhl (Code Review)" <ge...@cloudera.org>.
Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/19396 )

Change subject: IMPALA-11819: [DOCS] Add Iceberg LOAD DATA information
......................................................................


Patch Set 2: Code-Review+1

LGTM!


-- 
To view, visit http://gerrit.cloudera.org:8080/19396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec242781a4551aa04e4e920e3f3a1010c7ab808e
Gerrit-Change-Number: 19396
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Jan 2023 08:00:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11819: [DOCS] Add Iceberg LOAD DATA information

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19396 )

Change subject: IMPALA-11819: [DOCS] Add Iceberg LOAD DATA information
......................................................................


Patch Set 2:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/689/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/19396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec242781a4551aa04e4e920e3f3a1010c7ab808e
Gerrit-Change-Number: 19396
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sun, 08 Jan 2023 10:27:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11819: [DOCS] Add Iceberg LOAD DATA information

Posted by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org>.
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/19396 )

Change subject: IMPALA-11819: [DOCS] Add Iceberg LOAD DATA information
......................................................................


Patch Set 2: Code-Review+1

Nice and clear, LGTM!


-- 
To view, visit http://gerrit.cloudera.org:8080/19396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec242781a4551aa04e4e920e3f3a1010c7ab808e
Gerrit-Change-Number: 19396
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Jan 2023 09:41:26 +0000
Gerrit-HasComments: No