You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by "sandynz (via GitHub)" <gi...@apache.org> on 2023/06/01 08:03:21 UTC

[GitHub] [shardingsphere] sandynz commented on a diff in pull request #25983: Fix replication slot not remove when drop database at openGauss

sandynz commented on code in PR #25983:
URL: https://github.com/apache/shardingsphere/pull/25983#discussion_r1212752139


##########
kernel/data-pipeline/dialect/opengauss/src/main/java/org/apache/shardingsphere/data/pipeline/opengauss/ingest/OpenGaussWALDumper.java:
##########
@@ -59,7 +59,7 @@ public final class OpenGaussWALDumper extends AbstractLifecycleExecutor implemen
     
     private final DumperConfiguration dumperConfig;
     
-    private final WALPosition walPosition;
+    private WALPosition walPosition;

Review Comment:
   Could we use AtomicReference?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org