You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@servicemix.apache.org by "Ron Gavlin (JIRA)" <ji...@apache.org> on 2008/11/20 04:08:05 UTC

[jira] Created: (SM-1697) new smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS

new smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS
-------------------------------------------------------------------------------------------------------------------------

                 Key: SM-1697
                 URL: https://issues.apache.org/activemq/browse/SM-1697
             Project: ServiceMix
          Issue Type: Bug
          Components: servicemix-jms
    Affects Versions: servicemix-jms-2008.01
            Reporter: Ron Gavlin


New smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS. 



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (SM-1697) new smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS

Posted by "Ron Gavlin (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/activemq/browse/SM-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47504#action_47504 ] 

Ron Gavlin commented on SM-1697:
--------------------------------

Do you agree this specific property should converted to/from a String when being set or retrieved from the JMS message?

> new smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SM-1697
>                 URL: https://issues.apache.org/activemq/browse/SM-1697
>             Project: ServiceMix
>          Issue Type: Bug
>          Components: servicemix-jms
>    Affects Versions: servicemix-jms-2008.01
>            Reporter: Ron Gavlin
>
> New smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (SM-1697) new smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS

Posted by "Ron Gavlin (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/activemq/browse/SM-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ron Gavlin updated SM-1697:
---------------------------

    Attachment: sm-1697.patch

Patch to blacklist JbiConstants.DATESTAMP_PROPERTY_NAME

> new smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SM-1697
>                 URL: https://issues.apache.org/activemq/browse/SM-1697
>             Project: ServiceMix
>          Issue Type: Bug
>          Components: servicemix-jms
>    Affects Versions: servicemix-jms-2008.01
>            Reporter: Ron Gavlin
>         Attachments: sm-1697.patch
>
>
> New smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (SM-1697) new smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS

Posted by "Ron Gavlin (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/activemq/browse/SM-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ron Gavlin updated SM-1697:
---------------------------

    Patch Info: [Patch Available]

> new smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SM-1697
>                 URL: https://issues.apache.org/activemq/browse/SM-1697
>             Project: ServiceMix
>          Issue Type: Bug
>          Components: servicemix-jms
>    Affects Versions: servicemix-jms-2008.01
>            Reporter: Ron Gavlin
>         Attachments: sm-1697.patch
>
>
> New smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (SM-1697) new smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS

Posted by "Ron Gavlin (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/activemq/browse/SM-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ron Gavlin updated SM-1697:
---------------------------

    Attachment: sm-1697-revised.patch

This patch excludes invalid header properties from being set.

> new smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SM-1697
>                 URL: https://issues.apache.org/activemq/browse/SM-1697
>             Project: ServiceMix
>          Issue Type: Bug
>          Components: servicemix-jms
>    Affects Versions: servicemix-jms-2008.01
>            Reporter: Ron Gavlin
>         Attachments: sm-1697-revised.patch, sm-1697.patch
>
>
> New smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (SM-1697) new smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS

Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/activemq/browse/SM-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47511#action_47511 ] 

Guillaume Nodet commented on SM-1697:
-------------------------------------

Why does that fail ?
The copyPropertiesFromNM method should only copy properties that have a simple type (String, Number and Dates) to JMS properties, so my guess is that the Calendar should not appear there.

> new smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SM-1697
>                 URL: https://issues.apache.org/activemq/browse/SM-1697
>             Project: ServiceMix
>          Issue Type: Bug
>          Components: servicemix-jms
>    Affects Versions: servicemix-jms-2008.01
>            Reporter: Ron Gavlin
>         Attachments: sm-1697.patch
>
>
> New smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (SM-1697) new smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS

Posted by "Ron Gavlin (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/activemq/browse/SM-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47645#action_47645 ] 

Ron Gavlin commented on SM-1697:
--------------------------------

Would it be possible to also backport this patch to the SMX 3.2.x branch?

> new smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SM-1697
>                 URL: https://issues.apache.org/activemq/browse/SM-1697
>             Project: ServiceMix
>          Issue Type: Bug
>          Components: servicemix-jms
>    Affects Versions: servicemix-jms-2008.01
>            Reporter: Ron Gavlin
>         Attachments: sm-1697-revised.patch, sm-1697.patch
>
>
> New smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (SM-1697) new smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS

Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/activemq/browse/SM-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47528#action_47528 ] 

Guillaume Nodet commented on SM-1697:
-------------------------------------

I think we should just drop non compliant properties.

> new smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SM-1697
>                 URL: https://issues.apache.org/activemq/browse/SM-1697
>             Project: ServiceMix
>          Issue Type: Bug
>          Components: servicemix-jms
>    Affects Versions: servicemix-jms-2008.01
>            Reporter: Ron Gavlin
>         Attachments: sm-1697.patch
>
>
> New smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (SM-1697) new smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS

Posted by "Ron Gavlin (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/activemq/browse/SM-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47526#action_47526 ] 

Ron Gavlin commented on SM-1697:
--------------------------------

Oops, it appears my test case is bad. It should be setting property JbiConstants.DATESTAMP_PROPERTY_NAME with a java.util.Date object instead of a Calendar object. This is what we are seeing in my real-world scenario when the JMSException gets thrown. It appears a java.util.Date object will pass thru the simple type filter. According to the JMS spec, (see the "Message Properties" section of http://java.sun.com/j2ee/1.4/docs/api/javax/jms/Message.html) java.util.Date is not a valid JMS Message Property. 

Based on this document, it appears the simple type filter should be written based on the following statement:

"The setObjectProperty method accepts values of class Boolean, Byte, Short, Integer, Long, Float, Double, and String. An attempt to use any other class must throw a JMSException."

So, either we automatically exclude values not specified in the above list, or we take responsibility for marshalling specific types like java.util.Date. What are your thoughts?

/Ron

> new smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SM-1697
>                 URL: https://issues.apache.org/activemq/browse/SM-1697
>             Project: ServiceMix
>          Issue Type: Bug
>          Components: servicemix-jms
>    Affects Versions: servicemix-jms-2008.01
>            Reporter: Ron Gavlin
>         Attachments: sm-1697.patch
>
>
> New smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (SM-1697) new smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS

Posted by "Ron Gavlin (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/activemq/browse/SM-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47532#action_47532 ] 

Ron Gavlin commented on SM-1697:
--------------------------------

OK, I will work on a patch that quietly drops non-compliant properties, where "compliant" is defined by the statement: 

"The setObjectProperty method accepts values of class Boolean, Byte, Short, Integer, Long, Float, Double, and String."

Thanks,

/Ron

> new smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SM-1697
>                 URL: https://issues.apache.org/activemq/browse/SM-1697
>             Project: ServiceMix
>          Issue Type: Bug
>          Components: servicemix-jms
>    Affects Versions: servicemix-jms-2008.01
>            Reporter: Ron Gavlin
>         Attachments: sm-1697.patch
>
>
> New smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (SM-1697) new smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS

Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/activemq/browse/SM-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47512#action_47512 ] 

Guillaume Nodet commented on SM-1697:
-------------------------------------

I've just had a look and the test case works even when not blacklisting this property.

> new smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SM-1697
>                 URL: https://issues.apache.org/activemq/browse/SM-1697
>             Project: ServiceMix
>          Issue Type: Bug
>          Components: servicemix-jms
>    Affects Versions: servicemix-jms-2008.01
>            Reporter: Ron Gavlin
>         Attachments: sm-1697.patch
>
>
> New smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Issue Comment Edited: (SM-1697) new smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS

Posted by "Ron Gavlin (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/activemq/browse/SM-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47504#action_47504 ] 

rgavlin edited comment on SM-1697 at 11/19/08 8:54 PM:
----------------------------------------------------------

There appears to be no value in passing this exchange property over jms. As a result, it seems to make sense to automatically blacklist this property. I will attach a patch that blacklists this property from being passed to/from jms.

/Ron

      was (Author: rgavlin):
    Do you agree this specific property should converted to/from a String when being set or retrieved from the JMS message?
  
> new smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SM-1697
>                 URL: https://issues.apache.org/activemq/browse/SM-1697
>             Project: ServiceMix
>          Issue Type: Bug
>          Components: servicemix-jms
>    Affects Versions: servicemix-jms-2008.01
>            Reporter: Ron Gavlin
>
> New smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (SM-1697) new smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS

Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/activemq/browse/SM-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Guillaume Nodet resolved SM-1697.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 3.2.4
                   servicemix-jms-2008.02
         Assignee: Guillaume Nodet

Sending        src/main/java/org/apache/servicemix/jms/endpoints/AbstractJmsMarshaler.java
Sending        src/test/java/org/apache/servicemix/jms/JmsProviderEndpointTest.java
Transmitting file data ..
Committed revision 722022.

Sending        servicemix-jms/src/main/java/org/apache/servicemix/jms/endpoints/AbstractJmsMarshaler.java
Sending        servicemix-jms/src/test/java/org/apache/servicemix/jms/JmsProviderEndpointTest.java
Transmitting file data ..
Committed revision 722023.

> new smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SM-1697
>                 URL: https://issues.apache.org/activemq/browse/SM-1697
>             Project: ServiceMix
>          Issue Type: Bug
>          Components: servicemix-jms
>    Affects Versions: servicemix-jms-2008.01
>            Reporter: Ron Gavlin
>            Assignee: Guillaume Nodet
>             Fix For: servicemix-jms-2008.02, 3.2.4
>
>         Attachments: sm-1697-revised.patch, sm-1697.patch
>
>
> New smx-jms marshaler throws exception attempting to copy property "JbiConstants.DATESTAMP_PROPERTY_NAME" from NMR to JMS. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.