You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@polaris.apache.org by "adutra (via GitHub)" <gi...@apache.org> on 2026/02/06 15:20:31 UTC

[PR] [Iceberg 1.11] Update REST spec [polaris]

adutra opened a new pull request, #3687:
URL: https://github.com/apache/polaris/pull/3687

   This isn't the definitive spec for 1.11, so it will have to be updated again later.
   
   <!--
   📝 Describe what changes you're proposing, especially breaking or user-facing changes. 
   📖 See https://github.com/apache/polaris/blob/main/CONTRIBUTING.md for more.
   -->
   
   ## Checklist
   - [ ] 🛡️ Don't disclose security issues! (contact security@apache.org)
   - [ ] 🔗 Clearly explained why the changes are needed, or linked related issues: Fixes #
   - [ ] 🧪 Added/updated tests with good coverage, or manually tested (and explained how)
   - [ ] 💡 Added comments for complex logic
   - [ ] 🧾 Updated `CHANGELOG.md` (if needed)
   - [ ] 📚 Updated documentation in `site/content/in-dev/unreleased` (if needed)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Iceberg 1.11] Update REST spec [polaris]

Posted by "snazy (via GitHub)" <gi...@apache.org>.

snazy commented on code in PR #3687:
URL: https://github.com/apache/polaris/pull/3687#discussion_r2774777024


##########
spec/generated/bundled-polaris-catalog-service.yaml:
##########
@@ -4452,6 +4589,13 @@ components:
           message: The given namespace already exists
           type: AlreadyExistsException
           code: 409
+    NamespaceNotEmptyError:

Review Comment:
   This new one seems to demand other code changes.



##########
spec/generated/bundled-polaris-catalog-service.yaml:
##########
@@ -2715,14 +2774,18 @@ components:
         format-version:
           type: integer
           minimum: 1
-          maximum: 2
+          maximum: 3

Review Comment:
   Should we potentially add some safeguards to allow/disallow v3? (in a separate PR, of course)



##########
spec/generated/bundled-polaris-catalog-service.yaml:
##########
@@ -2845,6 +2913,10 @@ components:
           type: string
         metadata-location:
           type: string
+        overwrite:

Review Comment:
   This one cries for a feature/configuration toggle?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Iceberg 1.11] Update REST spec [polaris]

Posted by "snazy (via GitHub)" <gi...@apache.org>.

snazy commented on code in PR #3687:
URL: https://github.com/apache/polaris/pull/3687#discussion_r2774748689


##########
runtime/service/src/test/java/org/apache/polaris/service/catalog/iceberg/CommitTransactionEventTest.java:
##########
@@ -177,6 +178,7 @@ private void createCatalogAndNamespace(
             .createNamespace(
                 catalog,
                 createNamespaceRequest,
+                UUID.randomUUID(),

Review Comment:
   That's fine IMO. We can revisit later, when needed. Mind adding a TODO?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Iceberg 1.11] Update REST spec [polaris]

Posted by "adutra (via GitHub)" <gi...@apache.org>.

adutra commented on code in PR #3687:
URL: https://github.com/apache/polaris/pull/3687#discussion_r2774808690


##########
spec/generated/bundled-polaris-catalog-service.yaml:
##########
@@ -2845,6 +2913,10 @@ components:
           type: string
         metadata-location:
           type: string
+        overwrite:

Review Comment:
   See: https://github.com/apache/iceberg/pull/15248
   
   It's optional, so I think we are fine.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Iceberg 1.11] Update REST spec [polaris]

Posted by "adutra (via GitHub)" <gi...@apache.org>.

adutra commented on code in PR #3687:
URL: https://github.com/apache/polaris/pull/3687#discussion_r2774814900


##########
spec/generated/bundled-polaris-catalog-service.yaml:
##########
@@ -4452,6 +4589,13 @@ components:
           message: The given namespace already exists
           type: AlreadyExistsException
           code: 409
+    NamespaceNotEmptyError:

Review Comment:
   Good point, I'll investigate.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Iceberg 1.11] Update REST spec [polaris]

Posted by "adutra (via GitHub)" <gi...@apache.org>.

adutra commented on code in PR #3687:
URL: https://github.com/apache/polaris/pull/3687#discussion_r2774683753


##########
runtime/service/src/test/java/org/apache/polaris/service/catalog/iceberg/CommitTransactionEventTest.java:
##########
@@ -177,6 +178,7 @@ private void createCatalogAndNamespace(
             .createNamespace(
                 catalog,
                 createNamespaceRequest,
+                UUID.randomUUID(),

Review Comment:
   Note: random UUIDs are not UUID v7! This will have to be changed if/when we decide to support idempotency keys.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Iceberg 1.11] Update REST spec [polaris]

Posted by "snazy (via GitHub)" <gi...@apache.org>.

snazy commented on code in PR #3687:
URL: https://github.com/apache/polaris/pull/3687#discussion_r2774753849


##########
runtime/service/src/test/java/org/apache/polaris/service/catalog/iceberg/CommitTransactionEventTest.java:
##########
@@ -177,6 +178,7 @@ private void createCatalogAndNamespace(
             .createNamespace(
                 catalog,
                 createNamespaceRequest,
+                UUID.randomUUID(),

Review Comment:
   Or you use a 
   ```
   static final UUID NULL_UUID = new UUID(0L, 0L);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Iceberg 1.11] Update REST spec [polaris]

Posted by "adutra (via GitHub)" <gi...@apache.org>.

adutra merged PR #3687:
URL: https://github.com/apache/polaris/pull/3687


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org