You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/04/25 11:33:45 UTC

[GitHub] [netbeans] mishrasandeep commented on a diff in pull request #3343: [NETBEANS-6241] - Fixed switchToRuleSwitch Hint for BindingPattern and GuardedPattern

mishrasandeep commented on code in PR #3343:
URL: https://github.com/apache/netbeans/pull/3343#discussion_r857529010


##########
java/java.source.base/src/org/netbeans/modules/java/source/save/CasualDiff.java:
##########
@@ -1966,8 +1967,23 @@ protected int diffBindingPattern(JCBindingPattern oldT, JCBindingPattern newT, i
 
     protected int diffCase(JCCase oldT, JCCase newT, int[] bounds) {
         int localPointer = bounds[0];
-        List<JCExpression> oldPatterns = getCasePatterns(oldT);
-        List<JCExpression> newPatterns = getCasePatterns(newT);
+        List<? extends JCTree> oldPatterns;
+        List<? extends JCTree> newPatterns;
+        
+        if(TreeShims.isJDKVersionRelease17_Or_Above() && 

Review Comment:
   Thanks for the input. have adressed the comments and removed reflection access wherever possible.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists