You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/12/17 23:53:44 UTC

[GitHub] [airflow] milton0825 commented on a change in pull request #5663: [AIRFLOW-4940] Add DynamoDB to S3 operator

milton0825 commented on a change in pull request #5663: [AIRFLOW-4940] Add DynamoDB to S3 operator
URL: https://github.com/apache/airflow/pull/5663#discussion_r359090217
 
 

 ##########
 File path: tests/contrib/operators/test_dynamodb_to_s3.py
 ##########
 @@ -0,0 +1,77 @@
+# -*- coding: utf-8 -*-
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+from multiprocessing import SimpleQueue
 
 Review comment:
   No good reason. I think initially I was using multiprocessing to do the s3 upload but later decided not to and I guess the tests did not get updated.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services