You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "jwilliams-ocient (via GitHub)" <gi...@apache.org> on 2023/06/29 20:33:27 UTC
[GitHub] [superset] jwilliams-ocient opened a new pull request, #24556: chore: set max version for pyocient. Version 3.0 renames a data type …
jwilliams-ocient opened a new pull request, #24556:
URL: https://github.com/apache/superset/pull/24556
…class
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jwilliams-ocient closed pull request #24556: chore: set max version for pyocient. Version 3.0 renames a data type …
Posted by "jwilliams-ocient (via GitHub)" <gi...@apache.org>.
jwilliams-ocient closed pull request #24556: chore: set max version for pyocient. Version 3.0 renames a data type …
URL: https://github.com/apache/superset/pull/24556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #24556: chore: set max version for pyocient. Version 3.0 renames a data type …
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #24556:
URL: https://github.com/apache/superset/pull/24556#issuecomment-1622133887
Hi @jwilliams-ocient. Thanks for the PR. Could you add a description to your PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #24556: fix: set max version for pyocient
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina merged PR #24556:
URL: https://github.com/apache/superset/pull/24556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jwilliams-ocient commented on pull request #24556: chore: set max version for pyocient. Version 3.0 renames a data type …
Posted by "jwilliams-ocient (via GitHub)" <gi...@apache.org>.
jwilliams-ocient commented on PR #24556:
URL: https://github.com/apache/superset/pull/24556#issuecomment-1623964633
Thanks for taking a look @michael-s-molina ! My apologies for not providing a description 🤦🏾 . Lmk if you have any more questions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24556: chore: set max version for pyocient. Version 3.0 renames a data type …
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24556:
URL: https://github.com/apache/superset/pull/24556#issuecomment-1613785274
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24556?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24556](https://app.codecov.io/gh/apache/superset/pull/24556?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (eb48835) into [master](https://app.codecov.io/gh/apache/superset/commit/19deb9141d82826a6892d690a5c0b39a18fa39e6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (19deb91) will **decrease** coverage by `0.15%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eb48835 differs from pull request most recent head 58fe29d. Consider uploading reports for the commit 58fe29d to get more accurate results
```diff
@@ Coverage Diff @@
## master #24556 +/- ##
==========================================
- Coverage 58.26% 58.11% -0.15%
==========================================
Files 1906 1906
Lines 74120 74120
Branches 8154 8154
==========================================
- Hits 43186 43077 -109
- Misses 28815 28924 +109
Partials 2119 2119
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| presto | `53.83% <ø> (ø)` | |
| python | `60.64% <ø> (-0.31%)` | :arrow_down: |
| unit | `54.69% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 7 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24556/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina closed pull request #24556: chore: set max version for pyocient. Version 3.0 renames a data type …
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina closed pull request #24556: chore: set max version for pyocient. Version 3.0 renames a data type …
URL: https://github.com/apache/superset/pull/24556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org