You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Jesse Pangburn (JIRA)" <ji...@apache.org> on 2011/08/18 21:23:27 UTC

[jira] [Created] (CXF-3749) Using Dispatch API with Source type fails to set WS-Addressing action header properly in MESSAGE mode with SOAP 1.2

Using Dispatch API with Source type fails to set WS-Addressing action header properly in MESSAGE mode with SOAP 1.2
-------------------------------------------------------------------------------------------------------------------

                 Key: CXF-3749
                 URL: https://issues.apache.org/jira/browse/CXF-3749
             Project: CXF
          Issue Type: Bug
          Components: JAX-WS Runtime
    Affects Versions: 2.4.1
            Reporter: Jesse Pangburn
            Priority: Minor
         Attachments: patch3747and3748and3749.txt

Prior tests with PAYLOAD mode were successful with SOAP 1.2, but a quick test on MESSAGE mode with a StaxSource revealed that the WS-Addressing action header is not properly set in SOAP 1.2.  In one of the DispatchImpl.java's getPayloadElementName methods, there is the following code with a SOAP 1.1 namespace hardcoded:
            if (this.mode == Service.Mode.MESSAGE) {
                StaxUtils.skipToStartOfElement(reader);
                StaxUtils.toNextTag(reader,
                                    new QName("http://schemas.xmlsoap.org/soap/envelope/", "Body"));
                reader.nextTag();
                return reader.getName().toString();
            }

To work with SOAP 1.1 or SOAP 1.2, it should be changed to:
            if (this.mode == Service.Mode.MESSAGE) {
                StaxUtils.skipToStartOfElement(reader);
                StaxUtils.toNextTag(reader,
                                    new QName(ele.getNamespaceURI(), "Body"));
                reader.nextTag();
                return reader.getName().toString();
            }

I've tested this fix with a Source type in MESSAGE mode and it works with SOAP 1.1 and 1.2.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (CXF-3749) Using Dispatch API with Source type fails to set WS-Addressing action header properly in MESSAGE mode with SOAP 1.2

Posted by "Jesse Pangburn (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-3749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jesse Pangburn closed CXF-3749.
-------------------------------


Verified by downloading latest version of affected file(s) from SVN on the 2.4.x fixes branch and checked code contains the fix

> Using Dispatch API with Source type fails to set WS-Addressing action header properly in MESSAGE mode with SOAP 1.2
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: CXF-3749
>                 URL: https://issues.apache.org/jira/browse/CXF-3749
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-WS Runtime
>    Affects Versions: 2.4.1
>            Reporter: Jesse Pangburn
>            Assignee: Daniel Kulp
>            Priority: Minor
>              Labels: dispatch, jaxws, soap12
>             Fix For: 2.3.7, 2.4.3
>
>         Attachments: patch3747and3748and3749.txt
>
>
> Prior tests with PAYLOAD mode were successful with SOAP 1.2, but a quick test on MESSAGE mode with a StaxSource revealed that the WS-Addressing action header is not properly set in SOAP 1.2.  In one of the DispatchImpl.java's getPayloadElementName methods, there is the following code with a SOAP 1.1 namespace hardcoded:
>             if (this.mode == Service.Mode.MESSAGE) {
>                 StaxUtils.skipToStartOfElement(reader);
>                 StaxUtils.toNextTag(reader,
>                                     new QName("http://schemas.xmlsoap.org/soap/envelope/", "Body"));
>                 reader.nextTag();
>                 return reader.getName().toString();
>             }
> To work with SOAP 1.1 or SOAP 1.2, it should be changed to:
>             if (this.mode == Service.Mode.MESSAGE) {
>                 StaxUtils.skipToStartOfElement(reader);
>                 StaxUtils.toNextTag(reader,
>                                     new QName(ele.getNamespaceURI(), "Body"));
>                 reader.nextTag();
>                 return reader.getName().toString();
>             }
> I've tested this fix with a Source type in MESSAGE mode and it works with SOAP 1.1 and 1.2.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (CXF-3749) Using Dispatch API with Source type fails to set WS-Addressing action header properly in MESSAGE mode with SOAP 1.2

Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-3749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Kulp resolved CXF-3749.
------------------------------

       Resolution: Fixed
    Fix Version/s: 2.4.3


Patch applied, but I had to fix some checkstyle issues and I also used our DOMUtils.getFirstElement to get the first element.

Major thanks for the patch though!

> Using Dispatch API with Source type fails to set WS-Addressing action header properly in MESSAGE mode with SOAP 1.2
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: CXF-3749
>                 URL: https://issues.apache.org/jira/browse/CXF-3749
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-WS Runtime
>    Affects Versions: 2.4.1
>            Reporter: Jesse Pangburn
>            Assignee: Daniel Kulp
>            Priority: Minor
>              Labels: dispatch, jaxws, soap12
>             Fix For: 2.4.3
>
>         Attachments: patch3747and3748and3749.txt
>
>
> Prior tests with PAYLOAD mode were successful with SOAP 1.2, but a quick test on MESSAGE mode with a StaxSource revealed that the WS-Addressing action header is not properly set in SOAP 1.2.  In one of the DispatchImpl.java's getPayloadElementName methods, there is the following code with a SOAP 1.1 namespace hardcoded:
>             if (this.mode == Service.Mode.MESSAGE) {
>                 StaxUtils.skipToStartOfElement(reader);
>                 StaxUtils.toNextTag(reader,
>                                     new QName("http://schemas.xmlsoap.org/soap/envelope/", "Body"));
>                 reader.nextTag();
>                 return reader.getName().toString();
>             }
> To work with SOAP 1.1 or SOAP 1.2, it should be changed to:
>             if (this.mode == Service.Mode.MESSAGE) {
>                 StaxUtils.skipToStartOfElement(reader);
>                 StaxUtils.toNextTag(reader,
>                                     new QName(ele.getNamespaceURI(), "Body"));
>                 reader.nextTag();
>                 return reader.getName().toString();
>             }
> I've tested this fix with a Source type in MESSAGE mode and it works with SOAP 1.1 and 1.2.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CXF-3749) Using Dispatch API with Source type fails to set WS-Addressing action header properly in MESSAGE mode with SOAP 1.2

Posted by "Jesse Pangburn (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-3749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jesse Pangburn updated CXF-3749:
--------------------------------

    Attachment: patch3747and3748and3749.txt

Since I've patched two other defects on this same file in the same revision, this patch fixes those defects as well as this one.

> Using Dispatch API with Source type fails to set WS-Addressing action header properly in MESSAGE mode with SOAP 1.2
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: CXF-3749
>                 URL: https://issues.apache.org/jira/browse/CXF-3749
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-WS Runtime
>    Affects Versions: 2.4.1
>            Reporter: Jesse Pangburn
>            Priority: Minor
>              Labels: dispatch, jaxws, soap12
>         Attachments: patch3747and3748and3749.txt
>
>
> Prior tests with PAYLOAD mode were successful with SOAP 1.2, but a quick test on MESSAGE mode with a StaxSource revealed that the WS-Addressing action header is not properly set in SOAP 1.2.  In one of the DispatchImpl.java's getPayloadElementName methods, there is the following code with a SOAP 1.1 namespace hardcoded:
>             if (this.mode == Service.Mode.MESSAGE) {
>                 StaxUtils.skipToStartOfElement(reader);
>                 StaxUtils.toNextTag(reader,
>                                     new QName("http://schemas.xmlsoap.org/soap/envelope/", "Body"));
>                 reader.nextTag();
>                 return reader.getName().toString();
>             }
> To work with SOAP 1.1 or SOAP 1.2, it should be changed to:
>             if (this.mode == Service.Mode.MESSAGE) {
>                 StaxUtils.skipToStartOfElement(reader);
>                 StaxUtils.toNextTag(reader,
>                                     new QName(ele.getNamespaceURI(), "Body"));
>                 reader.nextTag();
>                 return reader.getName().toString();
>             }
> I've tested this fix with a Source type in MESSAGE mode and it works with SOAP 1.1 and 1.2.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (CXF-3749) Using Dispatch API with Source type fails to set WS-Addressing action header properly in MESSAGE mode with SOAP 1.2

Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-3749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Kulp reassigned CXF-3749:
--------------------------------

    Assignee: Daniel Kulp

> Using Dispatch API with Source type fails to set WS-Addressing action header properly in MESSAGE mode with SOAP 1.2
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: CXF-3749
>                 URL: https://issues.apache.org/jira/browse/CXF-3749
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-WS Runtime
>    Affects Versions: 2.4.1
>            Reporter: Jesse Pangburn
>            Assignee: Daniel Kulp
>            Priority: Minor
>              Labels: dispatch, jaxws, soap12
>         Attachments: patch3747and3748and3749.txt
>
>
> Prior tests with PAYLOAD mode were successful with SOAP 1.2, but a quick test on MESSAGE mode with a StaxSource revealed that the WS-Addressing action header is not properly set in SOAP 1.2.  In one of the DispatchImpl.java's getPayloadElementName methods, there is the following code with a SOAP 1.1 namespace hardcoded:
>             if (this.mode == Service.Mode.MESSAGE) {
>                 StaxUtils.skipToStartOfElement(reader);
>                 StaxUtils.toNextTag(reader,
>                                     new QName("http://schemas.xmlsoap.org/soap/envelope/", "Body"));
>                 reader.nextTag();
>                 return reader.getName().toString();
>             }
> To work with SOAP 1.1 or SOAP 1.2, it should be changed to:
>             if (this.mode == Service.Mode.MESSAGE) {
>                 StaxUtils.skipToStartOfElement(reader);
>                 StaxUtils.toNextTag(reader,
>                                     new QName(ele.getNamespaceURI(), "Body"));
>                 reader.nextTag();
>                 return reader.getName().toString();
>             }
> I've tested this fix with a Source type in MESSAGE mode and it works with SOAP 1.1 and 1.2.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CXF-3749) Using Dispatch API with Source type fails to set WS-Addressing action header properly in MESSAGE mode with SOAP 1.2

Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-3749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Kulp updated CXF-3749:
-----------------------------

    Fix Version/s: 2.3.7

> Using Dispatch API with Source type fails to set WS-Addressing action header properly in MESSAGE mode with SOAP 1.2
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: CXF-3749
>                 URL: https://issues.apache.org/jira/browse/CXF-3749
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-WS Runtime
>    Affects Versions: 2.4.1
>            Reporter: Jesse Pangburn
>            Assignee: Daniel Kulp
>            Priority: Minor
>              Labels: dispatch, jaxws, soap12
>             Fix For: 2.3.7, 2.4.3
>
>         Attachments: patch3747and3748and3749.txt
>
>
> Prior tests with PAYLOAD mode were successful with SOAP 1.2, but a quick test on MESSAGE mode with a StaxSource revealed that the WS-Addressing action header is not properly set in SOAP 1.2.  In one of the DispatchImpl.java's getPayloadElementName methods, there is the following code with a SOAP 1.1 namespace hardcoded:
>             if (this.mode == Service.Mode.MESSAGE) {
>                 StaxUtils.skipToStartOfElement(reader);
>                 StaxUtils.toNextTag(reader,
>                                     new QName("http://schemas.xmlsoap.org/soap/envelope/", "Body"));
>                 reader.nextTag();
>                 return reader.getName().toString();
>             }
> To work with SOAP 1.1 or SOAP 1.2, it should be changed to:
>             if (this.mode == Service.Mode.MESSAGE) {
>                 StaxUtils.skipToStartOfElement(reader);
>                 StaxUtils.toNextTag(reader,
>                                     new QName(ele.getNamespaceURI(), "Body"));
>                 reader.nextTag();
>                 return reader.getName().toString();
>             }
> I've tested this fix with a Source type in MESSAGE mode and it works with SOAP 1.1 and 1.2.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira