You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/21 06:34:40 UTC

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8930: ARROW-10929: [Rust] Change CI to use Stable Rust

jorgecarleitao commented on a change in pull request #8930:
URL: https://github.com/apache/arrow/pull/8930#discussion_r546532338



##########
File path: rust/datafusion/src/logical_plan/plan.rs
##########
@@ -561,6 +561,7 @@ impl From<&PlanType> for String {
 
 /// Represents some sort of execution plan, in String form
 #[derive(Debug, Clone, PartialEq)]
+#[allow(clippy::rc_buffer)]

Review comment:
       I agree @Dandandan . I changed then a couple of times, but since the focus of this PR was the CI in stable, which includes build, tests, etc. I considered clippy to be a minor hassle that we can deal with later.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org