You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andy Pang <pa...@huawei.com> on 2016/04/15 05:54:58 UTC
Review Request 46249: Support hook/module process operation before
main process initialize.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46249/
-----------------------------------------------------------
Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
Repository: mesos
Description
-------
If we in hook/module manager use libprocess library, it will auto use process initialize fucntion, as the process::initialize will only call once,then in the main fucnton process initialize process::initialize("master") will not be called. So the HTTP request process "delegate" will be wrong, http request will not be response.
Diffs
-----
src/master/main.cpp ea7f0fc
Diff: https://reviews.apache.org/r/46249/diff/
Testing
-------
make check
Thanks,
Andy Pang
Re: Review Request 46249: Hook and module process operation before
main process initialize.
Posted by Andy Pang <pa...@huawei.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46249/
-----------------------------------------------------------
(Updated 四月 18, 2016, 5:41 a.m.)
Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
Summary (updated)
-----------------
Hook and module process operation before main process initialize.
Repository: mesos
Description
-------
If we in hook/module manager use libprocess library, it will auto use process initialize fucntion, as the process::initialize will only call once,then in the main fucnton process initialize process::initialize("master") will not be called. So the HTTP request process "delegate" will be wrong, http request will not be response.
Diffs
-----
src/master/main.cpp ea7f0fc
Diff: https://reviews.apache.org/r/46249/diff/
Testing
-------
make check
Thanks,
Andy Pang
Re: Review Request 46249: Hook and module process operation before
main process initialize.
Posted by Vinod Kone <vi...@gmail.com>.
> On April 18, 2016, 3:06 a.m., Mesos ReviewBot wrote:
> > Bad patch!
> >
> > Reviews applied: [46249]
> >
> > Failed command: ./support/apply-review.sh -n -r 46249
> >
> > Error:
> > 2016-04-18 03:06:22 URL:https://reviews.apache.org/r/46249/diff/raw/ [1834/1834] -> "46249.patch" [1]
> > Total errors found: 0
> > Checking 1 files
> > Error: No line in the commit message summary may exceed 72 characters.
> >
> > Full log: https://builds.apache.org/job/mesos-reviewbot/12581/console
The error here is a bit confusing "no line in the commit message summary..." applies to both "Summary"and "Description" of the review. Going forward, please remember to line wrap the description at 72 chars also.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46249/#review129281
-----------------------------------------------------------
On April 18, 2016, 5:41 a.m., Andy Pang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46249/
> -----------------------------------------------------------
>
> (Updated April 18, 2016, 5:41 a.m.)
>
>
> Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If we in hook/module manager use libprocess library, it will auto use process initialize fucntion, as the process::initialize will only call once,then in the main fucnton process initialize process::initialize("master") will not be called. So the HTTP request process "delegate" will be wrong, http request will not be response.
>
>
> Diffs
> -----
>
> src/master/main.cpp ea7f0fc
>
> Diff: https://reviews.apache.org/r/46249/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Andy Pang
>
>
Re: Review Request 46249: hook/module process operation before main
process initialize.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46249/#review129281
-----------------------------------------------------------
Bad patch!
Reviews applied: [46249]
Failed command: ./support/apply-review.sh -n -r 46249
Error:
2016-04-18 03:06:22 URL:https://reviews.apache.org/r/46249/diff/raw/ [1834/1834] -> "46249.patch" [1]
Total errors found: 0
Checking 1 files
Error: No line in the commit message summary may exceed 72 characters.
Full log: https://builds.apache.org/job/mesos-reviewbot/12581/console
- Mesos ReviewBot
On April 18, 2016, 2:44 a.m., Andy Pang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46249/
> -----------------------------------------------------------
>
> (Updated April 18, 2016, 2:44 a.m.)
>
>
> Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If we in hook/module manager use libprocess library, it will auto use process initialize fucntion, as the process::initialize will only call once,then in the main fucnton process initialize process::initialize("master") will not be called. So the HTTP request process "delegate" will be wrong, http request will not be response.
>
>
> Diffs
> -----
>
> src/master/main.cpp ea7f0fc
>
> Diff: https://reviews.apache.org/r/46249/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Andy Pang
>
>
Re: Review Request 46249: hook/module process operation before main
process initialize.
Posted by Andy Pang <pa...@huawei.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46249/
-----------------------------------------------------------
(Updated 四月 18, 2016, 2:44 a.m.)
Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
Repository: mesos
Description
-------
If we in hook/module manager use libprocess library, it will auto use process initialize fucntion, as the process::initialize will only call once,then in the main fucnton process initialize process::initialize("master") will not be called. So the HTTP request process "delegate" will be wrong, http request will not be response.
Diffs (updated)
-----
src/master/main.cpp ea7f0fc
Diff: https://reviews.apache.org/r/46249/diff/
Testing
-------
make check
Thanks,
Andy Pang
Re: Review Request 46249: hook/module process operation before main
process initialize.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46249/#review129278
-----------------------------------------------------------
src/master/main.cpp (lines 195 - 196)
<https://reviews.apache.org/r/46249/#comment192748>
Move this back to where it was. This needs to be called after `LIBPROCESS_*` environment variables are set.
Instead move the ModuleManager and HookManager initialization after `logging::initialize()`.
- Vinod Kone
On April 15, 2016, 8:09 a.m., Andy Pang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46249/
> -----------------------------------------------------------
>
> (Updated April 15, 2016, 8:09 a.m.)
>
>
> Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If we in hook/module manager use libprocess library, it will auto use process initialize fucntion, as the process::initialize will only call once,then in the main fucnton process initialize process::initialize("master") will not be called. So the HTTP request process "delegate" will be wrong, http request will not be response.
>
>
> Diffs
> -----
>
> src/master/main.cpp ea7f0fc
>
> Diff: https://reviews.apache.org/r/46249/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Andy Pang
>
>
Re: Review Request 46249: hook/module process operation before main
process initialize.
Posted by Andy Pang <pa...@huawei.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46249/
-----------------------------------------------------------
(Updated 四月 15, 2016, 8:09 a.m.)
Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
Summary (updated)
-----------------
hook/module process operation before main process initialize.
Repository: mesos
Description
-------
If we in hook/module manager use libprocess library, it will auto use process initialize fucntion, as the process::initialize will only call once,then in the main fucnton process initialize process::initialize("master") will not be called. So the HTTP request process "delegate" will be wrong, http request will not be response.
Diffs
-----
src/master/main.cpp ea7f0fc
Diff: https://reviews.apache.org/r/46249/diff/
Testing
-------
make check
Thanks,
Andy Pang
Re: Review Request 46249: Support hook/module process operation
before main process initialize.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46249/#review129072
-----------------------------------------------------------
Bad patch!
Reviews applied: [46249]
Failed command: ./support/apply-review.sh -n -r 46249
Error:
2016-04-15 07:30:52 URL:https://reviews.apache.org/r/46249/diff/raw/ [696/696] -> "46249.patch" [1]
Total errors found: 0
Checking 1 files
Error: No line in the commit message summary may exceed 72 characters.
Full log: https://builds.apache.org/job/mesos-reviewbot/12542/console
- Mesos ReviewBot
On April 15, 2016, 3:54 a.m., Andy Pang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46249/
> -----------------------------------------------------------
>
> (Updated April 15, 2016, 3:54 a.m.)
>
>
> Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If we in hook/module manager use libprocess library, it will auto use process initialize fucntion, as the process::initialize will only call once,then in the main fucnton process initialize process::initialize("master") will not be called. So the HTTP request process "delegate" will be wrong, http request will not be response.
>
>
> Diffs
> -----
>
> src/master/main.cpp ea7f0fc
>
> Diff: https://reviews.apache.org/r/46249/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Andy Pang
>
>