You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2022/01/05 19:49:10 UTC
[GitHub] [logging-log4j2] vorburger opened a new pull request #685: Fix broken PropertiesConfigurationTest
vorburger opened a new pull request #685:
URL: https://github.com/apache/logging-log4j2/pull/685
This fixes the problem seen e.g. on #684.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vorburger commented on pull request #685: Fix broken PropertiesConfigurationTest
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #685:
URL: https://github.com/apache/logging-log4j2/pull/685#issuecomment-1006028325
@garydgregory do you want to merge this when it passes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vorburger edited a comment on pull request #685: Fix broken PropertiesConfigurationTest
Posted by GitBox <gi...@apache.org>.
vorburger edited a comment on pull request #685:
URL: https://github.com/apache/logging-log4j2/pull/685#issuecomment-1006050959
Indeed, now the CI failed on Mac (only) due to this.
To me this actually seems more like a bug in `org.apache.commons.lang3.SystemUtils#getJavaIoTmpDir()` - it really should be consistent between platforms.
But until that's fixed, it's probably simplest to put a big platform specific `if (...)` around it...
@garydgregory it's probably simplest if I let you do whatever you deem best here to fix this, and step back and close this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] garydgregory commented on pull request #685: Fix broken PropertiesConfigurationTest
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #685:
URL: https://github.com/apache/logging-log4j2/pull/685#issuecomment-1006030286
Note the config file has a / in it so you end up with two /
What is in the sys temp dir prop has a / at the end too IIRC in macOS at least. AFK for a few hours.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vorburger closed pull request #685: Fix broken PropertiesConfigurationTest
Posted by GitBox <gi...@apache.org>.
vorburger closed pull request #685:
URL: https://github.com/apache/logging-log4j2/pull/685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] garydgregory commented on pull request #685: Fix broken PropertiesConfigurationTest
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #685:
URL: https://github.com/apache/logging-log4j2/pull/685#issuecomment-1006128671
Hi @vorburger
I fixed the test differently in branches `release-2.x` and `master`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vorburger commented on pull request #685: Fix broken PropertiesConfigurationTest
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #685:
URL: https://github.com/apache/logging-log4j2/pull/685#issuecomment-1006050959
Indeed, now the CI failed on Mac (only) due to this.
To me this actually seems more like a bug in `org.apache.commons.lang3.SystemUtils#getJavaIoTmpDir()` - it really should be consistent between platforms.
But until that's fixed, it's probably simplest to put a big platform specific if around it...
@garydgregory it's probably simplest if I let you do whatever you deem best here to fix this, and step back and close this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org