You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by shuai-xu <gi...@git.apache.org> on 2018/05/03 09:27:06 UTC

[GitHub] flink pull request #5951: [FLINK-9293] [runtime] SlotPool should check slot ...

GitHub user shuai-xu opened a pull request:

    https://github.com/apache/flink/pull/5951

    [FLINK-9293] [runtime] SlotPool should check slot id when accepting a slot offer with existing allocation id

    
    ## What is the purpose of the change
    
    *This pull request fix that job master will accept multi slot offers with same allocation id and make the later slots leak.*
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
    
    *(example:)*
      - *Run the SlotPoolTest*
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / no)
      - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shuai-xu/flink jira-9293

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5951.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5951
    
----
commit 22ae227e2a19ddf15890dcce779536687328d7ac
Author: shuai.xus <sh...@...>
Date:   2018-05-03T09:13:08Z

    [FLINK-9293] [runtime] SlotPool should check slot id when accepting a slot offer with existing allocation id

----


---

[GitHub] flink issue #5951: [FLINK-9293] [runtime] SlotPool should check slot id when...

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/5951
  
    Good catch! Thank you for the PR.
    
    Will try to review this asap...


---

[GitHub] flink pull request #5951: [FLINK-9293] [runtime] SlotPool should check slot ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5951


---