[lucene] branch branch_9x updated: LUCENE-10273: Deprecate SpanishMinimalStemmer in favor of SpanishPluralStemmer (#497)

[rm...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

rmuir pushed a commit to branch branch_9x
in repository https://gitbox.apache.org/repos/asf/lucene.git


The following commit(s) were added to refs/heads/branch_9x by this push:
     new 072b775  LUCENE-10273: Deprecate SpanishMinimalStemmer in favor of SpanishPluralStemmer (#497)
072b775 is described below

commit 072b775199781bc7fcbcc38bc641578e46c54a4a
Author: Robert Muir <rm...@apache.org>
AuthorDate: Wed Dec 1 14:24:58 2021 -0500

    LUCENE-10273: Deprecate SpanishMinimalStemmer in favor of SpanishPluralStemmer (#497)
    
    * LUCENE-10273: Deprecate SpanishMinimalStemmer in favor of SpanishPluralStemmer
    
    The new SpanishPluralStemmer is in fact more "minimal", less agressive
    stemming and normalization. For the user that wants only plural
    stemming, it is the better choice.
---
 lucene/CHANGES.txt                                                 | 3 ++-
 .../org/apache/lucene/analysis/es/SpanishMinimalStemFilter.java    | 3 +++
 .../apache/lucene/analysis/es/SpanishMinimalStemFilterFactory.java | 2 ++
 .../java/org/apache/lucene/analysis/es/SpanishMinimalStemmer.java  | 3 +++
 .../apache/lucene/analysis/es/TestSpanishMinimalStemFilter.java    | 7 ++++++-
 .../lucene/analysis/es/TestSpanishMinimalStemFilterFactory.java    | 7 ++++++-
 6 files changed, 22 insertions(+), 3 deletions(-)

diff --git a/lucene/CHANGES.txt b/lucene/CHANGES.txt
index 28c0528..57cb762 100644
--- a/lucene/CHANGES.txt
+++ b/lucene/CHANGES.txt
@@ -55,7 +55,8 @@ Bug Fixes
 
 Other
 ---------------------
-(No changes)
+
+* LUCENE-10273: Deprecate SpanishMinimalStemFilter in favor of SpanishPluralStemFilter. (Robert Muir)
 
 ======================= Lucene 9.0.0 =======================
 
diff --git a/lucene/analysis/common/src/java/org/apache/lucene/analysis/es/SpanishMinimalStemFilter.java b/lucene/analysis/common/src/java/org/apache/lucene/analysis/es/SpanishMinimalStemFilter.java
index 4033ff1..edf68cc 100644
--- a/lucene/analysis/common/src/java/org/apache/lucene/analysis/es/SpanishMinimalStemFilter.java
+++ b/lucene/analysis/common/src/java/org/apache/lucene/analysis/es/SpanishMinimalStemFilter.java
@@ -30,7 +30,10 @@ import org.apache.lucene.analysis.tokenattributes.KeywordAttribute;
  * <p>To prevent terms from being stemmed use an instance of {@link SetKeywordMarkerFilter} or a
  * custom {@link TokenFilter} that sets the {@link KeywordAttribute} before this {@link
  * TokenStream}.
+ *
+ * @deprecated Use {@link SpanishPluralStemFilter} instead.
  */
+@Deprecated
 public final class SpanishMinimalStemFilter extends TokenFilter {
   private final SpanishMinimalStemmer stemmer = new SpanishMinimalStemmer();
   private final CharTermAttribute termAtt = addAttribute(CharTermAttribute.class);
diff --git a/lucene/analysis/common/src/java/org/apache/lucene/analysis/es/SpanishMinimalStemFilterFactory.java b/lucene/analysis/common/src/java/org/apache/lucene/analysis/es/SpanishMinimalStemFilterFactory.java
index f748f5f..9526704 100644
--- a/lucene/analysis/common/src/java/org/apache/lucene/analysis/es/SpanishMinimalStemFilterFactory.java
+++ b/lucene/analysis/common/src/java/org/apache/lucene/analysis/es/SpanishMinimalStemFilterFactory.java
@@ -34,7 +34,9 @@ import org.apache.lucene.analysis.TokenStream;
  * &lt;/fieldType&gt;</pre>
  *
  * @lucene.spi {@value #NAME}
+ * @deprecated Use {@link SpanishPluralStemFilterFactory} instead
  */
+@Deprecated
 public class SpanishMinimalStemFilterFactory extends TokenFilterFactory {
 
   /** SPI name */
diff --git a/lucene/analysis/common/src/java/org/apache/lucene/analysis/es/SpanishMinimalStemmer.java b/lucene/analysis/common/src/java/org/apache/lucene/analysis/es/SpanishMinimalStemmer.java
index 44cbfcb..fd1957c 100644
--- a/lucene/analysis/common/src/java/org/apache/lucene/analysis/es/SpanishMinimalStemmer.java
+++ b/lucene/analysis/common/src/java/org/apache/lucene/analysis/es/SpanishMinimalStemmer.java
@@ -21,7 +21,10 @@ package org.apache.lucene.analysis.es;
  * Minimal plural stemmer for Spanish.
  *
  * <p>This stemmer implements the "plurals" stemmer for spanish lanugage.
+ *
+ * @deprecated Use {@link SpanishPluralStemmer} instead.
  */
+@Deprecated
 public class SpanishMinimalStemmer {
 
   public int stem(char[] s, int len) {
diff --git a/lucene/analysis/common/src/test/org/apache/lucene/analysis/es/TestSpanishMinimalStemFilter.java b/lucene/analysis/common/src/test/org/apache/lucene/analysis/es/TestSpanishMinimalStemFilter.java
index 7c7047d..7cd511e 100644
--- a/lucene/analysis/common/src/test/org/apache/lucene/analysis/es/TestSpanishMinimalStemFilter.java
+++ b/lucene/analysis/common/src/test/org/apache/lucene/analysis/es/TestSpanishMinimalStemFilter.java
@@ -25,7 +25,12 @@ import org.apache.lucene.analysis.Tokenizer;
 import org.apache.lucene.analysis.core.KeywordTokenizer;
 import org.apache.lucene.analysis.en.EnglishMinimalStemFilter;
 
-/** Simple tests for {@link SpanishMinimalStemFilter} */
+/**
+ * Simple tests for {@link SpanishMinimalStemFilter}
+ *
+ * @deprecated Remove with SpanishMinimalStemFilter
+ */
+@Deprecated
 public class TestSpanishMinimalStemFilter extends BaseTokenStreamTestCase {
   private Analyzer analyzer;
 
diff --git a/lucene/analysis/common/src/test/org/apache/lucene/analysis/es/TestSpanishMinimalStemFilterFactory.java b/lucene/analysis/common/src/test/org/apache/lucene/analysis/es/TestSpanishMinimalStemFilterFactory.java
index 5c17cff..d71615e 100644
--- a/lucene/analysis/common/src/test/org/apache/lucene/analysis/es/TestSpanishMinimalStemFilterFactory.java
+++ b/lucene/analysis/common/src/test/org/apache/lucene/analysis/es/TestSpanishMinimalStemFilterFactory.java
@@ -24,7 +24,12 @@ import org.apache.lucene.analysis.MockTokenizer;
 import org.apache.lucene.analysis.TokenStream;
 import org.apache.lucene.analysis.Tokenizer;
 
-/** Simple tests to ensure the spanish minimal stem factory is working. */
+/**
+ * Simple tests to ensure the spanish minimal stem factory is working.
+ *
+ * @deprecated Remove with SpanishMinimalStemFilterFactory
+ */
+@Deprecated
 public class TestSpanishMinimalStemFilterFactory extends BaseTokenStreamFactoryTestCase {
   public void testStemming() throws Exception {
     Reader reader = new StringReader("camisetas");