You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/09 13:23:39 UTC
[GitHub] [airflow] XD-DENG opened a new pull request #14679: Fix minor issues in 'Concepts' doc
XD-DENG opened a new pull request #14679:
URL: https://github.com/apache/airflow/pull/14679
Reading through the doc and found some issues in [`Concepts` doc page](https://airflow.apache.org/docs/apache-airflow/stable/concepts.html).
Some clarifications will be added in-line below.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14679: Fix minor issues in 'Concepts' doc
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14679:
URL: https://github.com/apache/airflow/pull/14679#issuecomment-793902035
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG merged pull request #14679: Fix minor issues in 'Concepts' doc
Posted by GitBox <gi...@apache.org>.
XD-DENG merged pull request #14679:
URL: https://github.com/apache/airflow/pull/14679
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on a change in pull request #14679: Fix minor issues in 'Concepts' doc
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on a change in pull request #14679:
URL: https://github.com/apache/airflow/pull/14679#discussion_r590366039
##########
File path: docs/apache-airflow/concepts.rst
##########
@@ -134,7 +134,7 @@ any of its operators. This makes it easy to apply a common parameter to many ope
dag = DAG('my_dag', default_args=default_args)
op = DummyOperator(task_id='dummy', dag=dag)
- print(op.owner) # Airflow
+ print(op.owner) # airflow
Review comment:
To be consistent with the value above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on a change in pull request #14679: Fix minor issues in 'Concepts' doc
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on a change in pull request #14679:
URL: https://github.com/apache/airflow/pull/14679#discussion_r590365352
##########
File path: docs/apache-airflow/concepts.rst
##########
@@ -1641,7 +1641,7 @@ A ``.airflowignore`` file specifies the directories or files in ``DAG_FOLDER``
or ``PLUGINS_FOLDER`` that Airflow should intentionally ignore.
Each line in ``.airflowignore`` specifies a regular expression pattern,
and directories or files whose names (not DAG id) match any of the patterns
-would be ignored (under the hood,``Pattern.search()`` is used to match the pattern).
Review comment:
Currently this is not rendered properly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org