You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2012/06/28 16:27:30 UTC

[Bug 53481] New: Support SSL_OP_CIPHER_SERVER_PREFERENCE / SSLHonorCipherOrder

https://issues.apache.org/bugzilla/show_bug.cgi?id=53481

          Priority: P2
            Bug ID: 53481
          Assignee: dev@tomcat.apache.org
           Summary: Support SSL_OP_CIPHER_SERVER_PREFERENCE /
                    SSLHonorCipherOrder
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: mike@normi.net
          Hardware: All
            Status: NEW
           Version: 1.1.24
         Component: Library
           Product: Tomcat Native

Currently, Tomcat Native does not have an equivalent of the mod_ssl
SSLHonorCipherOrder directive and is thus vulnerable to the SSL BEAST attack.

See http://httpd.apache.org/docs/current/mod/mod_ssl.html#sslhonorcipherorder
for the docs on this directive, and
https://community.qualys.com/blogs/securitylabs/2011/10/17/mitigating-the-beast-attack-on-tls
on why and how it mitigates the BEAST attack.

Please incorporate an option named SSLHonorCipherOrder that sets the OpenSSL
option SSL_OP_CIPHER_SERVER_PREFERENCE

P.S., not sure whether to qualify this as bug or enhancement, but since it
concerns a security issue I filed it as a bug.

P.S.2, I'm willing to create a patch myself, but since I don't have an Tomcat
Native build env that will probably take some time... It's a really small
change.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 53481] Support SSL_OP_CIPHER_SERVER_PREFERENCE / SSLHonorCipherOrder

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53481

--- Comment #3 from Christopher Schultz <ch...@christopherschultz.net> ---
Nope, SSL_CTX_set_options (which is what SSLContext.setOptions calls) only
flips the bit(s) passed-into it, so the patch is fine.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 53481] Support SSL_OP_CIPHER_SERVER_PREFERENCE / SSLHonorCipherOrder

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53481

--- Comment #6 from Christopher Schultz <ch...@christopherschultz.net> ---
(In reply to comment #5)
> Note that this feature requires an updated version of Tomcat Native.
> See bug 53969 for details.

Specifically, tcnative 1.1.25 or later.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 53481] Support SSL_OP_CIPHER_SERVER_PREFERENCE / SSLHonorCipherOrder

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53481

--- Comment #2 from Christopher Schultz <ch...@christopherschultz.net> ---
I'm looking at applying this, but I have to check on what SSLContext.setOptions
does -- I think the patch will un-set previously-set options when setting
SSL_HONOR_CIPHER_ORDER. Once I verify the behavior of SSLContext.setOptions,
I'll make any necessary adjustments.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 53481] Support SSL_OP_CIPHER_SERVER_PREFERENCE / SSLHonorCipherOrder

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53481

Christopher Schultz <ch...@christopherschultz.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |53969

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 53481] Support SSL_OP_CIPHER_SERVER_PREFERENCE / SSLHonorCipherOrder

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53481

--- Comment #5 from Konstantin Kolinko <kn...@gmail.com> ---
Note that this feature requires an updated version of Tomcat Native.
See bug 53969 for details.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 53481] Support SSL_OP_CIPHER_SERVER_PREFERENCE / SSLHonorCipherOrder

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53481

Bug 53481 depends on bug 53969, which changed state.

Bug 53969 Summary: JNI method hasOp only supports SSL_OP_ALLOW_UNSAFE_LEGACY_RENEGOTIATION and should support others
https://issues.apache.org/bugzilla/show_bug.cgi?id=53969

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 53481] Support SSL_OP_CIPHER_SERVER_PREFERENCE / SSLHonorCipherOrder

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53481

Christopher Schultz <ch...@christopherschultz.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Christopher Schultz <ch...@christopherschultz.net> ---
Fixed in trunk and 7.0.x. Will be included in Tomcat 7.0.30.

Proposed for 6.0.x.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 53481] Support SSL_OP_CIPHER_SERVER_PREFERENCE / SSLHonorCipherOrder

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53481

--- Comment #1 from sebek64@post.cz ---
Created attachment 29148
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=29148&action=edit
Patch that adds SSLHonorCipherOrder option

Actually, this can be already supported by current tcnative, but it needs to be
added to tomcat itself. I've created a patch (should fit both 7.x and 8.x
sources). It is compile-tested only. Perhaps it would be a good idea to
reassign this bug to a more appropriate project.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 53481] Support SSL_OP_CIPHER_SERVER_PREFERENCE / SSLHonorCipherOrder

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53481

--- Comment #7 from Christopher Schultz <ch...@christopherschultz.net> ---
Fixed in Tomcat 6.0.x. Will be in Tomcat 6.0.37.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org