You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/02/14 09:50:12 UTC

[GitHub] [apisix] tylitianrui commented on a change in pull request #6314: fix(hmac-auth): hmac-auth plugin sort array param

tylitianrui commented on a change in pull request #6314:
URL: https://github.com/apache/apisix/pull/6314#discussion_r805667916



##########
File path: apisix/plugins/hmac-auth.lua
##########
@@ -244,7 +244,13 @@ local function generate_signature(ctx, secret_key, params)
 
             -- whether to encode the uri parameters
             if type(param) == "table" then
+                local vals = {}

Review comment:
       i  wonder that  why not use table.new




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org