You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/06/06 18:18:15 UTC
[GitHub] [iceberg] kbendick opened a new pull request, #4974: [Infra] Add explicit call to revapi github action to ensure it's not skipped
kbendick opened a new pull request, #4974:
URL: https://github.com/apache/iceberg/pull/4974
The revapi action is sometimes skipping.
This is possibly due to the cache (in which case we'd need to be more explicit about which dependencies are cached).
We can either try this or `./gradlew clean :iceberg-api:build -x test -x integrationTest -x javadoc` to try it out. I'm open to either.
I'll look into the revapi action upstream to see if there's a better way we can force it or if they have any guidance. This worked locally for me though as `clean` should force `iceberg-api:revapi` to invoke `build`.
cc @singhpk234 @ajantha-bhat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] ajantha-bhat commented on pull request #4974: [Infra] Add explicit call to revapi github action to ensure it's not skipped
Posted by GitBox <gi...@apache.org>.
ajantha-bhat commented on PR #4974:
URL: https://github.com/apache/iceberg/pull/4974#issuecomment-1148127916
can we also do some dummy changes in the `api/` module (until the review is done)? So, it will run the rev api check? Now out of 26 checks it ran, I don't see the rev api check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #4974: [Infra] Add explicit call to revapi github action to ensure it's not skipped
Posted by GitBox <gi...@apache.org>.
kbendick commented on PR #4974:
URL: https://github.com/apache/iceberg/pull/4974#issuecomment-1147746050
I think we can also mark this as not up to date, or run this particular action _without_ clean, but with `--rerun-tasks`.
See https://stackoverflow.com/questions/42175235/force-gradle-to-run-task-even-if-it-is-up-to-date
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #4974: [Infra] Add explicit call to revapi github action to ensure it's not skipped
Posted by GitBox <gi...@apache.org>.
kbendick commented on PR #4974:
URL: https://github.com/apache/iceberg/pull/4974#issuecomment-1149053363
Replaced by https://github.com/apache/iceberg/pull/4989
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a diff in pull request #4974: [Infra] Add explicit call to revapi github action to ensure it's not skipped
Posted by GitBox <gi...@apache.org>.
kbendick commented on code in PR #4974:
URL: https://github.com/apache/iceberg/pull/4974#discussion_r891610683
##########
.github/workflows/api-binary-compatibility.yml:
##########
@@ -46,7 +46,7 @@ jobs:
path: ~/.gradle/caches
key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle') }}
restore-keys: ${{ runner.os }}-gradle
- - run: ./gradlew :iceberg-api:revapi
+ - run: ./gradlew clean :iceberg-api:revapi -x test -x integrationTest -x javadoc
Review Comment:
No, not entirely.
The problem, as outlined in the new PR https://github.com/apache/iceberg/pull/4989, was that the `actions/checkout` github action uses a depth of `1` by default.
So the "head" (master) branch is in a detached state, and thus the tags needed for the action to work (basically the output of `git describe`) was failing.
I _did_ remove the cache, which then caused the tests to at least run `revapi`. But they still passed because the plugin couldn't properly determine the old version (via the tag) and then the new version via the override in the `.palantir/revapi.yaml` file).
Let's continue the discussion in https://github.com/apache/iceberg/pull/4989
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] findepi commented on a diff in pull request #4974: [Infra] Add explicit call to revapi github action to ensure it's not skipped
Posted by GitBox <gi...@apache.org>.
findepi commented on code in PR #4974:
URL: https://github.com/apache/iceberg/pull/4974#discussion_r891105585
##########
.github/workflows/api-binary-compatibility.yml:
##########
@@ -46,7 +46,7 @@ jobs:
path: ~/.gradle/caches
key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle') }}
restore-keys: ${{ runner.os }}-gradle
- - run: ./gradlew :iceberg-api:revapi
+ - run: ./gradlew clean :iceberg-api:revapi -x test -x integrationTest -x javadoc
Review Comment:
is `:iceberg-api:revapi` success cached from earlier runs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick closed pull request #4974: [Infra] Add explicit call to revapi github action to ensure it's not skipped
Posted by GitBox <gi...@apache.org>.
kbendick closed pull request #4974: [Infra] Add explicit call to revapi github action to ensure it's not skipped
URL: https://github.com/apache/iceberg/pull/4974
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org