You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "amym-li (via GitHub)" <gi...@apache.org> on 2025/11/29 06:06:24 UTC
[PR] chore(ts): Migrate Divider.jsx to Divider.tsx [SIP-36] [superset]
amym-li opened a new pull request, #36335:
URL: https://github.com/apache/superset/pull/36335
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
To migrate the Divider component, the following steps were performed:
1. Renamed the index file from `index.js` => `index.ts`
2. Renamed the component file from `Divider.jsx` => `Divider.tsx`
3. Made the following type changes in `Divider.tsx`:
- Replaced the `propTypes` const with an `interface DividerProps` definition
- Typed callbacks and functions to their expected values
4. Renamed the test file from `Divider.test.jsx` => `Divider.test.tsx`
5. Made the following type changes in `Divider.test.tsx`
- Typed the `props` const to `DividerProps`
- Typed callbacks and functions to their expected values
6. Resolved eslint warnings and errors.
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
CI and unit tests. Add a Divider layout element to a dashboard and confirm that it renders as expected.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: https://github.com/apache/superset/issues/9101
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
to: @rusackas @msyavuz @justinpark @sadpandajoe @geido
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(ts): Migrate Divider.jsx to Divider.tsx [SIP-36] [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #36335:
URL: https://github.com/apache/superset/pull/36335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(ts): Migrate Divider.jsx to Divider.tsx [SIP-36] [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #36335:
URL: https://github.com/apache/superset/pull/36335#issuecomment-3593288164
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(ts): Migrate Divider.jsx to Divider.tsx [SIP-36] [superset]
Posted by "danawan0409 (via GitHub)" <gi...@apache.org>.
danawan0409 commented on PR #36335:
URL: https://github.com/apache/superset/pull/36335#issuecomment-3593287616
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(ts): Migrate Divider.jsx to Divider.tsx [SIP-36] [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #36335:
URL: https://github.com/apache/superset/pull/36335#issuecomment-3598339751
Still seeing some type errors on this.
Also, FWIW, I just learned there's a claude script in the repo that might be able to help with these conversions. You're welcome to try `.claude/commands/js-to-ts.md` and see if that works? ¯\\\_(ツ)_/¯
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(ts): Migrate Divider.jsx to Divider.tsx [SIP-36] [superset]
Posted by "amym-li (via GitHub)" <gi...@apache.org>.
amym-li commented on PR #36335:
URL: https://github.com/apache/superset/pull/36335#issuecomment-3667898293
Seems `FiltersConfigModal.test.tsx` timed out during CI but it's passing locally when I run
```bash
npm test -- src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.test.tsx
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(ts): Migrate Divider.jsx to Divider.tsx [SIP-36] [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #36335:
URL: https://github.com/apache/superset/pull/36335#issuecomment-3591030952
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(ts): Migrate Divider.jsx to Divider.tsx [SIP-36] [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #36335:
URL: https://github.com/apache/superset/pull/36335#issuecomment-3667747232
CodeAnt AI is running Incremental review
---
### Thanks for using CodeAnt! 🎉
We're free for open-source projects. if you're enjoying it, help us grow by sharing.
[Share on X](https://twitter.com/intent/tweet?text=Just%20tried%20%40CodeAntAI%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A&url=https%3A//codeant.ai) ·
[Reddit](https://www.reddit.com/submit?title=Check%20out%20CodeAnt%20for%20automated%20code%20review&text=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A%20https%3A//codeant.ai) ·
[LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcodeant.ai&mini=true&title=Check%20out%20CodeAnt%20for%20automated%20code%20review&summary=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(ts): Migrate Divider.jsx to Divider.tsx [SIP-36] [superset]
Posted by "amym-li (via GitHub)" <gi...@apache.org>.
amym-li commented on PR #36335:
URL: https://github.com/apache/superset/pull/36335#issuecomment-3604740844
These type errors also seem to be related to https://github.com/apache/superset/pull/36336. I've rebased onto master so it should be resolved now.
I've also verified with `npm run type`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(ts): Migrate Divider.jsx to Divider.tsx [SIP-36] [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #36335:
URL: https://github.com/apache/superset/pull/36335#issuecomment-3604697713
CodeAnt AI is reviewing your PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org