You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2021/05/02 14:14:44 UTC
svn commit: r1889409 - in
/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/taggedpdf:
PDExportFormatAttributeObject.java PDLayoutAttributeObject.java
PDTableAttributeObject.java
Author: tilman
Date: Sun May 2 14:14:43 2021
New Revision: 1889409
URL: http://svn.apache.org/viewvc?rev=1889409&view=rev
Log:
PDFBOX-4892: remove unneeded code, as suggested by valerybokov
Modified:
pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/taggedpdf/PDExportFormatAttributeObject.java
pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/taggedpdf/PDLayoutAttributeObject.java
pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/taggedpdf/PDTableAttributeObject.java
Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/taggedpdf/PDExportFormatAttributeObject.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/taggedpdf/PDExportFormatAttributeObject.java?rev=1889409&r1=1889408&r2=1889409&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/taggedpdf/PDExportFormatAttributeObject.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/taggedpdf/PDExportFormatAttributeObject.java Sun May 2 14:14:43 2021
@@ -242,11 +242,11 @@ public class PDExportFormatAttributeObje
}
if (this.isSpecified(PDTableAttributeObject.ROW_SPAN))
{
- sb.append(", RowSpan=").append(String.valueOf(this.getRowSpan()));
+ sb.append(", RowSpan=").append(this.getRowSpan());
}
if (this.isSpecified(PDTableAttributeObject.COL_SPAN))
{
- sb.append(", ColSpan=").append(String.valueOf(this.getColSpan()));
+ sb.append(", ColSpan=").append(this.getColSpan());
}
if (this.isSpecified(PDTableAttributeObject.HEADERS))
{
Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/taggedpdf/PDLayoutAttributeObject.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/taggedpdf/PDLayoutAttributeObject.java?rev=1889409&r1=1889408&r2=1889409&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/taggedpdf/PDLayoutAttributeObject.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/taggedpdf/PDLayoutAttributeObject.java Sun May 2 14:14:43 2021
@@ -1518,7 +1518,7 @@ public class PDLayoutAttributeObject ext
}
else
{
- sb.append(String.valueOf(borderThickness));
+ sb.append(borderThickness);
}
}
if (this.isSpecified(PADDING))
@@ -1531,7 +1531,7 @@ public class PDLayoutAttributeObject ext
}
else
{
- sb.append(String.valueOf(padding));
+ sb.append(padding);
}
}
if (this.isSpecified(COLOR))
@@ -1541,27 +1541,27 @@ public class PDLayoutAttributeObject ext
if (this.isSpecified(SPACE_BEFORE))
{
sb.append(", SpaceBefore=")
- .append(String.valueOf(this.getSpaceBefore()));
+ .append(this.getSpaceBefore());
}
if (this.isSpecified(SPACE_AFTER))
{
sb.append(", SpaceAfter=")
- .append(String.valueOf(this.getSpaceAfter()));
+ .append(this.getSpaceAfter());
}
if (this.isSpecified(START_INDENT))
{
sb.append(", StartIndent=")
- .append(String.valueOf(this.getStartIndent()));
+ .append(this.getStartIndent());
}
if (this.isSpecified(END_INDENT))
{
sb.append(", EndIndent=")
- .append(String.valueOf(this.getEndIndent()));
+ .append(this.getEndIndent());
}
if (this.isSpecified(TEXT_INDENT))
{
sb.append(", TextIndent=")
- .append(String.valueOf(this.getTextIndent()));
+ .append(this.getTextIndent());
}
if (this.isSpecified(TEXT_ALIGN))
{
@@ -1573,29 +1573,11 @@ public class PDLayoutAttributeObject ext
}
if (this.isSpecified(WIDTH))
{
- Object width = this.getWidth();
- sb.append(", Width=");
- if (width instanceof Float)
- {
- sb.append(String.valueOf(width));
- }
- else
- {
- sb.append(width);
- }
+ sb.append(", Width=").append(this.getWidth());
}
if (this.isSpecified(HEIGHT))
{
- Object height = this.getHeight();
- sb.append(", Height=");
- if (height instanceof Float)
- {
- sb.append(String.valueOf(height));
- }
- else
- {
- sb.append(height);
- }
+ sb.append(", Height=").append(this.getHeight());
}
if (this.isSpecified(BLOCK_ALIGN))
{
@@ -1628,26 +1610,16 @@ public class PDLayoutAttributeObject ext
}
else
{
- sb.append(String.valueOf(tPadding));
+ sb.append(tPadding);
}
}
if (this.isSpecified(BASELINE_SHIFT))
{
- sb.append(", BaselineShift=")
- .append(String.valueOf(this.getBaselineShift()));
+ sb.append(", BaselineShift=").append(this.getBaselineShift());
}
if (this.isSpecified(LINE_HEIGHT))
{
- Object lineHeight = this.getLineHeight();
- sb.append(", LineHeight=");
- if (lineHeight instanceof Float)
- {
- sb.append(String.valueOf(lineHeight));
- }
- else
- {
- sb.append(lineHeight);
- }
+ sb.append(", LineHeight=").append(this.getLineHeight());
}
if (this.isSpecified(TEXT_DECORATION_COLOR))
{
@@ -1657,7 +1629,7 @@ public class PDLayoutAttributeObject ext
if (this.isSpecified(TEXT_DECORATION_THICKNESS))
{
sb.append(", TextDecorationThickness=")
- .append(String.valueOf(this.getTextDecorationThickness()));
+ .append(this.getTextDecorationThickness());
}
if (this.isSpecified(TEXT_DECORATION_TYPE))
{
@@ -1680,7 +1652,7 @@ public class PDLayoutAttributeObject ext
if (this.isSpecified(COLUMN_COUNT))
{
sb.append(", ColumnCount=")
- .append(String.valueOf(this.getColumnCount()));
+ .append(this.getColumnCount());
}
if (this.isSpecified(COLUMN_GAP))
{
@@ -1692,7 +1664,7 @@ public class PDLayoutAttributeObject ext
}
else
{
- sb.append(String.valueOf(columnGap));
+ sb.append(columnGap);
}
}
if (this.isSpecified(COLUMN_WIDTHS))
@@ -1705,7 +1677,7 @@ public class PDLayoutAttributeObject ext
}
else
{
- sb.append(String.valueOf(columnWidth));
+ sb.append(columnWidth);
}
}
return sb.toString();
Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/taggedpdf/PDTableAttributeObject.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/taggedpdf/PDTableAttributeObject.java?rev=1889409&r1=1889408&r2=1889409&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/taggedpdf/PDTableAttributeObject.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/taggedpdf/PDTableAttributeObject.java Sun May 2 14:14:43 2021
@@ -196,11 +196,11 @@ public class PDTableAttributeObject exte
StringBuilder sb = new StringBuilder().append(super.toString());
if (this.isSpecified(ROW_SPAN))
{
- sb.append(", RowSpan=").append(String.valueOf(this.getRowSpan()));
+ sb.append(", RowSpan=").append(this.getRowSpan());
}
if (this.isSpecified(COL_SPAN))
{
- sb.append(", ColSpan=").append(String.valueOf(this.getColSpan()));
+ sb.append(", ColSpan=").append(this.getColSpan());
}
if (this.isSpecified(HEADERS))
{