You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2018/05/01 00:36:43 UTC

[kudu-CR] Revert unneccesary change to test in test scanner.py in commit 3bf125f469a2929f7fe20e4e31f073376f37575d. The test test scan rows string predicate and projection was already working and using column names is both easier to read and more reliable in the eve 

andy@phdata.io has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10255


Change subject: Revert unneccesary change to test in test_scanner.py in commit 3bf125f469a2929f7fe20e4e31f073376f37575d. The test test_scan_rows_string_predicate_and_projection was already working and using column names is both easier to read and more reliable in the eve
......................................................................

Revert unneccesary change to test in test_scanner.py in commit
3bf125f469a2929f7fe20e4e31f073376f37575d. The test
test_scan_rows_string_predicate_and_projection was already working
and using column names is both easier to read and more reliable in
the even of a schema change than the column index numbers.

Change-Id: I12c900c1366fad61f5c04d023d80fea1f488ef19
---
M python/kudu/tests/test_scanner.py
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/10255/1
-- 
To view, visit http://gerrit.cloudera.org:8080/10255
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I12c900c1366fad61f5c04d023d80fea1f488ef19
Gerrit-Change-Number: 10255
Gerrit-PatchSet: 1
Gerrit-Owner: andy@phdata.io

[kudu-CR] python-client: fix test scan rows string predicate and projection

Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10255 )

Change subject: python-client: fix test_scan_rows_string_predicate_and_projection
......................................................................

python-client: fix test_scan_rows_string_predicate_and_projection

Revert unneccesary change to test in test_scanner.py in commit
3bf125f469a2929f7fe20e4e31f073376f37575d. The test
test_scan_rows_string_predicate_and_projection was already working
and using column names is both easier to read and more reliable in
the even of a schema change than the column index numbers.

Change-Id: I12c900c1366fad61f5c04d023d80fea1f488ef19
Reviewed-on: http://gerrit.cloudera.org:8080/10255
Tested-by: Kudu Jenkins
Reviewed-by: David Ribeiro Alves <da...@gmail.com>
---
M python/kudu/tests/test_scanner.py
1 file changed, 1 insertion(+), 3 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  David Ribeiro Alves: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/10255
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I12c900c1366fad61f5c04d023d80fea1f488ef19
Gerrit-Change-Number: 10255
Gerrit-PatchSet: 6
Gerrit-Owner: andy@phdata.io
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: andy@phdata.io

[kudu-CR] python-client: fix test scan rows string predicate and projection

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello David Ribeiro Alves, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/10255

to look at the new patch set (#3).

Change subject: python-client: fix test_scan_rows_string_predicate_and_projection
......................................................................

python-client: fix test_scan_rows_string_predicate_and_projection

Revert unneccesary change to test in test_scanner.py in commit
3bf125f469a2929f7fe20e4e31f073376f37575d. The test
test_scan_rows_string_predicate_and_projection was already working
and using column names is both easier to read and more reliable in
the even of a schema change than the column index numbers.

Change-Id: I12c900c1366fad61f5c04d023d80fea1f488ef19
---
M python/kudu/tests/test_scanner.py
1 file changed, 1 insertion(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/10255/3
-- 
To view, visit http://gerrit.cloudera.org:8080/10255
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I12c900c1366fad61f5c04d023d80fea1f488ef19
Gerrit-Change-Number: 10255
Gerrit-PatchSet: 3
Gerrit-Owner: andy@phdata.io
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] python-client: fix test scan rows string predicate and projection

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/10255

to look at the new patch set (#2).

Change subject: python-client: fix test_scan_rows_string_predicate_and_projection
......................................................................

python-client: fix test_scan_rows_string_predicate_and_projection

Revert unneccesary change to test in test_scanner.py in commit
3bf125f469a2929f7fe20e4e31f073376f37575d. The test
test_scan_rows_string_predicate_and_projection was already working
and using column names is both easier to read and more reliable in
the even of a schema change than the column index numbers.

Change-Id: I12c900c1366fad61f5c04d023d80fea1f488ef19
---
M python/kudu/tests/test_scanner.py
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/10255/2
-- 
To view, visit http://gerrit.cloudera.org:8080/10255
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I12c900c1366fad61f5c04d023d80fea1f488ef19
Gerrit-Change-Number: 10255
Gerrit-PatchSet: 2
Gerrit-Owner: andy@phdata.io
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] python-client: fix test scan rows string predicate and projection

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/10255 )

Change subject: python-client: fix test_scan_rows_string_predicate_and_projection
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/10255
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I12c900c1366fad61f5c04d023d80fea1f488ef19
Gerrit-Change-Number: 10255
Gerrit-PatchSet: 5
Gerrit-Owner: andy@phdata.io
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: andy@phdata.io
Gerrit-Comment-Date: Tue, 01 May 2018 17:48:31 +0000
Gerrit-HasComments: No

[kudu-CR] python-client: fix test scan rows string predicate and projection

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello David Ribeiro Alves, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/10255

to look at the new patch set (#5).

Change subject: python-client: fix test_scan_rows_string_predicate_and_projection
......................................................................

python-client: fix test_scan_rows_string_predicate_and_projection

Revert unneccesary change to test in test_scanner.py in commit
3bf125f469a2929f7fe20e4e31f073376f37575d. The test
test_scan_rows_string_predicate_and_projection was already working
and using column names is both easier to read and more reliable in
the even of a schema change than the column index numbers.

Change-Id: I12c900c1366fad61f5c04d023d80fea1f488ef19
---
M python/kudu/tests/test_scanner.py
1 file changed, 1 insertion(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/10255/5
-- 
To view, visit http://gerrit.cloudera.org:8080/10255
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I12c900c1366fad61f5c04d023d80fea1f488ef19
Gerrit-Change-Number: 10255
Gerrit-PatchSet: 5
Gerrit-Owner: andy@phdata.io
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: andy@phdata.io

[kudu-CR] python-client: fix test scan rows string predicate and projection

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello David Ribeiro Alves, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/10255

to look at the new patch set (#4).

Change subject: python-client: fix test_scan_rows_string_predicate_and_projection
......................................................................

python-client: fix test_scan_rows_string_predicate_and_projection

Revert unneccesary change to test in test_scanner.py in commit
3bf125f469a2929f7fe20e4e31f073376f37575d. The test
test_scan_rows_string_predicate_and_projection was already working
and using column names is both easier to read and more reliable in
the even of a schema change than the column index numbers.

Change-Id: I12c900c1366fad61f5c04d023d80fea1f488ef19
---
M python/kudu/tests/test_scanner.py
1 file changed, 1 insertion(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/10255/4
-- 
To view, visit http://gerrit.cloudera.org:8080/10255
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I12c900c1366fad61f5c04d023d80fea1f488ef19
Gerrit-Change-Number: 10255
Gerrit-PatchSet: 4
Gerrit-Owner: andy@phdata.io
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: andy@phdata.io

[kudu-CR] python-client: fix test scan rows string predicate and projection

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/10255 )

Change subject: python-client: fix test_scan_rows_string_predicate_and_projection
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10255/2/python/kudu/tests/test_scanner.py
File python/kudu/tests/test_scanner.py:

http://gerrit.cloudera.org:8080/#/c/10255/2/python/kudu/tests/test_scanner.py@74
PS2, Line 74: 
nit: since you're here mind removing the extra blank lines here and below until scanner.open() ?



-- 
To view, visit http://gerrit.cloudera.org:8080/10255
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I12c900c1366fad61f5c04d023d80fea1f488ef19
Gerrit-Change-Number: 10255
Gerrit-PatchSet: 2
Gerrit-Owner: andy@phdata.io
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 01 May 2018 00:42:00 +0000
Gerrit-HasComments: Yes

[kudu-CR] python-client: fix test scan rows string predicate and projection

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
andy@phdata.io has posted comments on this change. ( http://gerrit.cloudera.org:8080/10255 )

Change subject: python-client: fix test_scan_rows_string_predicate_and_projection
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10255/2/python/kudu/tests/test_scanner.py
File python/kudu/tests/test_scanner.py:

http://gerrit.cloudera.org:8080/#/c/10255/2/python/kudu/tests/test_scanner.py@74
PS2, Line 74:         sv = self.table['string_val']
> nit: since you're here mind removing the extra blank lines here and below u
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/10255
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I12c900c1366fad61f5c04d023d80fea1f488ef19
Gerrit-Change-Number: 10255
Gerrit-PatchSet: 3
Gerrit-Owner: andy@phdata.io
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: andy@phdata.io
Gerrit-Comment-Date: Tue, 01 May 2018 00:47:05 +0000
Gerrit-HasComments: Yes