[jira] [Updated] (ARTEMIS-5639) Fix MQTTRetainMessageManagerTest

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARTEMIS-5639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ASF GitHub Bot updated ARTEMIS-5639:
------------------------------------
    Labels: pull-request-available  (was: )

> Fix MQTTRetainMessageManagerTest
> --------------------------------
>
>                 Key: ARTEMIS-5639
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-5639
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> I noticed that MQTTRetainMessageManagerTest failed at one point on the test-suite, but the error message made no sense. On further investigation it turns out there's a bug in the assertion such that it compares two values, but the failure message references a value that wasn't actually tested. Furthermore, the assertion converts a {{byte[]}} to a {{String}}, but the {{byte[]}} is full of non-printable characters so it makes the error message more difficult to read than is really necessary. The test should instead use a human readable {{String}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@activemq.apache.org
For additional commands, e-mail: issues-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact