You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/12/03 20:53:40 UTC
Review Request 28668: Fixed a bug in the allocator's framework
activation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28668/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos-git
Description
-------
Looks like this is pretty old code, from git blame.
activateFramework() seems to imply one can change the role, however we don't actually support doing that!
See: https://issues.apache.org/jira/browse/MESOS-703
Diffs
-----
src/master/allocator.hpp 02d20d0cc802805bc702891306aa42894531b223
src/master/hierarchical_allocator_process.hpp fbaa23fad37fc6cbe870932cd4ace6622080001b
src/master/master.cpp c840d497d9486cde970b11ba79e12feb15ee9ccf
src/tests/allocator_tests.cpp 1fcbb4a4c7ada2b88443c635b76c294848ac13d8
src/tests/mesos.hpp f132c6caff471ce1be069f31eadb1d7e5d0f7dfd
Diff: https://reviews.apache.org/r/28668/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 28668: Fixed a bug in the allocator's framework
activation.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28668/#review63762
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Dec. 3, 2014, 7:53 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28668/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2014, 7:53 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Looks like this is pretty old code, from git blame.
>
> activateFramework() seems to imply one can change the role, however we don't actually support doing that!
> See: https://issues.apache.org/jira/browse/MESOS-703
>
>
> Diffs
> -----
>
> src/master/allocator.hpp 02d20d0cc802805bc702891306aa42894531b223
> src/master/hierarchical_allocator_process.hpp fbaa23fad37fc6cbe870932cd4ace6622080001b
> src/master/master.cpp c840d497d9486cde970b11ba79e12feb15ee9ccf
> src/tests/allocator_tests.cpp 1fcbb4a4c7ada2b88443c635b76c294848ac13d8
> src/tests/mesos.hpp f132c6caff471ce1be069f31eadb1d7e5d0f7dfd
>
> Diff: https://reviews.apache.org/r/28668/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>