You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Dies Koper <no...@github.com> on 2013/05/22 08:00:55 UTC
[jclouds-labs] makes more live tests pass on fgcp (#5)
this is an update of a (closed) PR of 30 min ago, as I noticed I was introducing new classes with the old jclouds header. Fixed in this PR.
You can merge this Pull Request by running:
git pull https://github.com/dkoper/jclouds-labs tests
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs/pull/5
-- Commit Summary --
* FGCP: add @Test(enabled = false) to public methods that are not tests
* FGCP: enable HttpApiMetadataTests for fgcp
* FGCP: catch exceptions when node is not in expected state when rebooting,
* FGCP: fix location description (was showing '1') and other minor cleanups.
* FGCP: throw IAE instead of AuthorizationException when pem can't be parsed
* FGCP: increase timeout for nonBlock test, cleanups
-- File Changes --
M fgcp-au/src/test/java/org/jclouds/fujitsu/fgcp/compute/FGCPAUComputeServiceLiveTest.java (3)
M fgcp-de/src/test/java/org/jclouds/fujitsu/fgcp/compute/FGCPDEComputeServiceLiveTest.java (1)
M fgcp/src/main/java/org/jclouds/fujitsu/fgcp/compute/strategy/FGCPComputeServiceAdapter.java (105)
A fgcp/src/main/java/org/jclouds/fujitsu/fgcp/handlers/FGCPBackoffLimitedRetryHandler.java (27)
M fgcp/src/main/java/org/jclouds/fujitsu/fgcp/handlers/FGCPServerErrorRetryHandler.java (5)
M fgcp/src/main/java/org/jclouds/fujitsu/fgcp/handlers/ResponseNotSuccessHandler.java (2)
M fgcp/src/main/java/org/jclouds/fujitsu/fgcp/location/SystemAndNetworkSegmentToLocationSupplier.java (2)
M fgcp/src/main/java/org/jclouds/fujitsu/fgcp/suppliers/FGCPCredentialsSupplier.java (7)
A fgcp/src/test/java/org/jclouds/fujitsu/fgcp/compute/FGCPApiMetadataTest.java (33)
M fgcp/src/test/java/org/jclouds/fujitsu/fgcp/compute/FGCPBaseComputeServiceLiveTest.java (162)
M fgcp/src/test/java/org/jclouds/fujitsu/fgcp/services/ErrorResponseExpectTest.java (37)
M fgcp/src/test/resources/responses/GetVSYSConfiguration-response.xml (2)
A fgcp/src/test/resources/responses/IllegalState_ALREADY_STOPPED-response.xml (5)
M fgcp/src/test/resources/responses/IllegalState_RECONFIG_ING-response.xml (2)
A fgcp/src/test/resources/responses/IllegalState_RUNNING-response.xml (5)
-- Patch Links --
https://github.com/jclouds/jclouds-labs/pull/5.patch
https://github.com/jclouds/jclouds-labs/pull/5.diff
Re: [jclouds-labs] makes more live tests pass on fgcp (#5)
Posted by Andrew Gaul <no...@github.com>.
+1, although jclouds/team-jclouds-labs does not have the correct permissions so I cannot immediately merge this.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/5#issuecomment-18376533
Re: [jclouds-labs] makes more live tests pass on fgcp (#5)
Posted by Dies Koper <no...@github.com>.
There is a mistake in Deltacloud's GIT workflow doc: It says the reviewer should close the PR after committing but actually the Deltacloud committers are not given permission to close other people's PRs either.
IIRC, the reason is related to preventing committers from accidentally pushing to the mirror.
We do try to put a link or commit id in the PR after pushing so the PR requester can easily check the PR was pushed correctly.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/5#issuecomment-18378246
Re: [jclouds-labs] makes more live tests pass on fgcp (#5)
Posted by Dies Koper <no...@github.com>.
Closed #5.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/5
Re: [jclouds-labs] makes more live tests pass on fgcp (#5)
Posted by Dies Koper <no...@github.com>.
Confirmed all have appeared on jclouds/jclouds-labs:
FGCP: increase timeout for nonBlock test, cleanups
5a7554bbcc
FGCP: fix location description (was showing '1') and other minor cleac c
65a99a50c8
FGCP: throw IAE instead of AuthorizationException when pem can't be pc c
449c095fd7
FGCP: catch exceptions when node is not in expected state when rebootc c
d3a180eff8
FGCP: enable HttpApiMetadataTests for fgcp
2f112861c7
FGCP: add @Test(enabled = false) to public methods that are not tests
b98dcf643a
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/5#issuecomment-18379044
Re: [jclouds-labs] makes more live tests pass on fgcp (#5)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs #45](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/45/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/5#issuecomment-18259249
Re: [jclouds-labs] makes more live tests pass on fgcp (#5)
Posted by Andrew Gaul <no...@github.com>.
I misunderstood the model for jclouds-labs. I pushed @dkoper commits but lack permission to close this pull request.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/5#issuecomment-18378092