You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "bersprockets (via GitHub)" <gi...@apache.org> on 2023/04/09 19:43:10 UTC
[GitHub] [spark] bersprockets opened a new pull request, #40717: [MINOR][SQL][TESTS] Tests in `SubquerySuite` should not drop view created in `beforeAll`
bersprockets opened a new pull request, #40717:
URL: https://github.com/apache/spark/pull/40717
### What changes were proposed in this pull request?
Change tests to avoid replacing and dropping a temporary view that is created in `SubquerySuite#beforeAll`.
### Why are the changes needed?
When I added a test for SPARK-42937, it tried to use the view `t`, which is created in `beforeAll`. But because other tests would replace and drop this view, the new test would fail. As a result, that new test had to re-create `t` from scratch.
This change will allow `t` to be used by new tests.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #40717: [MINOR][SQL][TESTS] Tests in `SubquerySuite` should not drop view created in `beforeAll`
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #40717: [MINOR][SQL][TESTS] Tests in `SubquerySuite` should not drop view created in `beforeAll`
URL: https://github.com/apache/spark/pull/40717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #40717: [MINOR][SQL][TESTS] Tests in `SubquerySuite` should not drop view created in `beforeAll`
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #40717:
URL: https://github.com/apache/spark/pull/40717#issuecomment-1501256952
Merged to master, branch-3.4 and branch-3.3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] bersprockets commented on a diff in pull request #40717: [MINOR][SQL][TESTS] Tests in `SubquerySuite` should not drop view created in `beforeAll`
Posted by "bersprockets (via GitHub)" <gi...@apache.org>.
bersprockets commented on code in PR #40717:
URL: https://github.com/apache/spark/pull/40717#discussion_r1161333229
##########
sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala:
##########
@@ -2699,22 +2699,17 @@ class SubquerySuite extends QueryTest
test("SPARK-42937: Outer join with subquery in condition") {
withSQLConf(SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "false",
SQLConf.WHOLESTAGE_CODEGEN_ENABLED.key -> "false") {
- withTempView("t2") {
- // this is the same as the view t created in beforeAll, but that gets dropped by
- // one of the tests above
- r.filter($"c".isNotNull && $"d".isNotNull).createOrReplaceTempView("t2")
Review Comment:
This test no longer needs to re-create `t` (here named `t2`), because `t` is now available for this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org