[GitHub] [ozone] kerneltime commented on a diff in pull request #4044: HDDS-7517. Register OM-S3G gRPC performance metrics

["kerneltime (via GitHub)" <gi...@apache.org>]

kerneltime commented on code in PR #4044:
URL: https://github.com/apache/ozone/pull/4044#discussion_r1110777457


##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/grpc/metrics/GrpcMetricsServerRequestInterceptor.java:
##########
@@ -0,0 +1,88 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.ozone.grpc.metrics;
+
+import com.google.protobuf.AbstractMessage;
+import io.grpc.ForwardingServerCallListener.SimpleForwardingServerCallListener;
+import io.grpc.Metadata;
+import io.grpc.ServerCall;
+import io.grpc.ServerCallHandler;
+import io.grpc.ServerInterceptor;
+
+/**
+ * Interceptor to gather metrics based on grpc server request.
+ */
+public class GrpcMetricsServerRequestInterceptor implements ServerInterceptor {
+
+  private final GrpcMetrics grpcMetrics;
+  private long receivedTime;
+  private long startTime;
+  private long endTime;
+
+  public GrpcMetricsServerRequestInterceptor(
+      GrpcMetrics grpcMetrics) {
+    super();
+    this.grpcMetrics = grpcMetrics;
+  }
+
+  @Override
+  public <ReqT, RespT> ServerCall.Listener<ReqT> interceptCall(
+      ServerCall<ReqT, RespT> serverCall, Metadata headers,
+      ServerCallHandler<ReqT, RespT> serverCallHandler) {
+
+    // received time
+    receivedTime = System.nanoTime();
+
+    return new SimpleForwardingServerCallListener<ReqT>(
+        serverCallHandler.startCall(serverCall, headers)) {
+
+      @Override
+      public void onMessage(ReqT message) {
+        // start time
+        startTime = System.nanoTime();
+
+        long messageSize = 0;
+        if (message instanceof AbstractMessage) {
+          AbstractMessage parsedMessage = (AbstractMessage) message;
+          messageSize += parsedMessage.getSerializedSize();
+        } else {
+          grpcMetrics.incrUnknownMessagesReceived();
+        }
+
+        grpcMetrics.incrReceivedBytes(messageSize);
+        super.onMessage(message);
+      }
+
+      @Override
+      public void onComplete() {
+        super.onComplete();
+        // end time
+        endTime = System.nanoTime();
+
+        int queueTime = (int) (startTime - receivedTime);
+        int processingTime = (int) (endTime - startTime);
+
+        // set metrics queue time
+        grpcMetrics.addGrpcQueueTime(queueTime);
+
+        // set metrics processing time
+        grpcMetrics.addGrpcProcessingTime(processingTime);

Review Comment:
   Can you attach a label for which request was received?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org