[GitHub] [hive] vineetgarg02 commented on a change in pull request #671: HIVE-21857

[GitBox <gi...@apache.org>]

vineetgarg02 commented on a change in pull request #671: HIVE-21857
URL: https://github.com/apache/hive/pull/671#discussion_r296057847
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdDistinctRowCount.java
 ##########
 @@ -61,17 +62,11 @@ private HiveRelMdDistinctRowCount() {
   @Override
   public Double getDistinctRowCount(RelNode rel, RelMetadataQuery mq, ImmutableBitSet groupKey,
       RexNode predicate) {
-    if (rel instanceof HiveTableScan) {
-      return getDistinctRowCount((HiveTableScan) rel, mq, groupKey, predicate);
-    }
-    /*
-     * For now use Calcite' default formulas for propagating NDVs up the Query
-     * Tree.
-     */
-    return super.getDistinctRowCount(rel, mq, groupKey, predicate);
+    return NumberUtil.multiply(mq.getRowCount(rel),
 
 Review comment:
   We don't take groupKey into consideration anymore? What is the reason behind this change?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org