You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "rtpsw (via GitHub)" <gi...@apache.org> on 2023/04/05 14:44:40 UTC

[GitHub] [arrow] rtpsw commented on a diff in pull request #34904: GH-34786: [C++] Fix output schema calculated by Substrait consumer for AggregateRel

rtpsw commented on code in PR #34904:
URL: https://github.com/apache/arrow/pull/34904#discussion_r1158624872


##########
cpp/src/arrow/acero/aggregate_node.cc:
##########
@@ -77,6 +78,19 @@ namespace acero {
 
 namespace {
 
+template <typename KernelType>
+struct ARROW_ACERO_EXPORT AggregateNodeArgs {

Review Comment:
   Yes, this was moved here from the header but has no effect here - should be removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org