You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/07/25 05:26:31 UTC

[GitHub] [incubator-apisix] UnderTreeTech opened a new issue #1901: bug: 500 error when bench limit-count plugin

UnderTreeTech opened a new issue #1901:
URL: https://github.com/apache/incubator-apisix/issues/1901


   limit count conf:
   policy: redis
   count: 100
   time_window: 60
   key: remote_addr
   os: CentOS 7.6
   benchmark tool: apache benchmark
   
   I got runtime error which result in 500 response when i bench 1million request, 1k concurrency by ab. The follow snippet is runtime error detail:
   ```
   lua entry thread aborted: runtime error: .../apisix/apisix/plugins/limit-count/limit-count-redis.lua:76: attempt to compare nil with number
   stack traceback:
   coroutine 0:
           .../apisix/apisix/plugins/limit-count/limit-count-redis.lua: in function 'incoming'
           /usr/local/apisix/apisix/plugins/limit-count.lua:121: in function 'phase_fun'
           /usr/local/apisix/apisix/init.lua:147: in function 'run_plugin'
           /usr/local/apisix/apisix/init.lua:385: in function 'http_access_phase'
           access_by_lua(nginx.conf:161):2: in main chunk
   ```
   
   @membphis @moonming 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] UnderTreeTech edited a comment on issue #1901: bug: 500 error when bench limit-count plugin

Posted by GitBox <gi...@apache.org>.
UnderTreeTech edited a comment on issue #1901:
URL: https://github.com/apache/incubator-apisix/issues/1901#issuecomment-663927890


   Another issue: in my bench scenario, the redis connections is much more than pool size, there are many timewait , close wait connections, Is pool connection is not reusable long connection? BTW, my pool size is 100 and keepalive timeout is 10 minutes. @membphis 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on issue #1901: bug: 500 error when bench limit-count plugin

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1901:
URL: https://github.com/apache/incubator-apisix/issues/1901#issuecomment-663985581


   one issue focus on one thing. if you have another question, please create a new issue.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on issue #1901: bug: 500 error when bench limit-count plugin

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1901:
URL: https://github.com/apache/incubator-apisix/issues/1901#issuecomment-663919637


   yes, that is a bug. we need to check the return value first.
   welcome PR ^_^


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] UnderTreeTech commented on issue #1901: bug: 500 error when bench limit-count plugin

Posted by GitBox <gi...@apache.org>.
UnderTreeTech commented on issue #1901:
URL: https://github.com/apache/incubator-apisix/issues/1901#issuecomment-663927890


   Another issue: in my bench scenario, the redis connections is much more than pool size, there are many timewait , close wait connections, Is pool connection is not reusable long connection? BTW, my pool size is 100 and keepalive timeout is 10 minutes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] membphis closed issue #1901: bug: 500 error when bench limit-count plugin

Posted by GitBox <gi...@apache.org>.
membphis closed issue #1901:
URL: https://github.com/apache/incubator-apisix/issues/1901


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org