[jira] Commented: (HADOOP-3653) test-patch target not working on hudson.zones.apache.org due to HADOOP-3480

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609782#action_12609782 ] 

Hadoop QA commented on HADOOP-3653:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12384817/fixHusondBreak3480.patch
  against trunk revision 673254.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 4 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2779/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2779/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2779/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2779/console

This message is automatically generated.

> test-patch target not working on hudson.zones.apache.org due to HADOOP-3480
> ---------------------------------------------------------------------------
>
>                 Key: HADOOP-3653
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3653
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.18.0
>            Reporter: Nigel Daley
>            Assignee: Brice Arnould
>            Priority: Blocker
>             Fix For: 0.18.0
>
>         Attachments: fixHusondBreak3480.patch
>
>
> HADOOP-3480 has broken the test-patch target run by the Hudson Hadoop-Patch job.  This is causing all patches to get a -1 on contrib testing.
> Also, the message is very confusing now.  This is what the console shows:
> {quote}
>     ...
>      [exec]     [junit] 08/06/26 14:34:57 INFO ipc.Server: IPC Server handler 9 on 44137: exiting
>      [exec] 
>      [exec] BUILD SUCCESSFUL
>      [exec] Total time: 4 minutes 2 seconds
>      [exec] Some jars are not declared in the Eclipse project.
>      [exec] 
>     ...
>      [exec] 
>      [exec]     -1 contrib tests.  The patch failed contrib unit tests.
>      [exec] 
>     ...
> {quote}
> The -1 comes from the "Some jars are not declared in the Eclipse project" line which is a warning caused by HADOOP-3480.  This needs to be improved.
> The problem arises from the fact that additional jar files are copied into the lib/ directory for clover (code coverage), checkstyle, etc by the test-patch process on Hudson.  Also, there are src/test/lib/ftp*.jar referenced in the ECLIPSE_DECLARED_JARS variable:
> {quote}
> echo $PRESENT_JARS
> lib/clover.jar lib/commons-cli-2.0-SNAPSHOT.jar lib/commons-codec-1.3.jar lib/commons-httpclient-3.0.1.jar lib/commons-logging-1.0.4.jar lib/commons-logging-api-1.0.4.jar lib/commons-net-1.4.1.jar lib/excluded/checkstyle-all-4.3.jar lib/jets3t-0.6.0.jar lib/jetty-5.1.4.jar lib/jetty-ext/commons-el.jar lib/jetty-ext/jasper-compiler.jar lib/jetty-ext/jasper-runtime.jar lib/jetty-ext/jsp-api.jar lib/junit-3.8.1.jar lib/kfs-0.1.3.jar lib/log4j-1.2.13.jar lib/oro-2.0.8.jar lib/rat-0.5.1.jar lib/servlet-api.jar lib/slf4j-api-1.4.3.jar lib/slf4j-log4j12-1.4.3.jar lib/xmlenc-0.52.jar
> echo $ECLIPSE_DECLARED_JARS
> lib/commons-cli-2.0-SNAPSHOT.jar lib/commons-codec-1.3.jar lib/commons-httpclient-3.0.1.jar lib/commons-logging-1.0.4.jar lib/commons-logging-api-1.0.4.jar lib/commons-net-1.4.1.jar lib/jets3t-0.6.0.jar lib/jetty-5.1.4.jar lib/jetty-ext/commons-el.jar lib/jetty-ext/jasper-compiler.jar lib/jetty-ext/jasper-runtime.jar lib/jetty-ext/jsp-api.jar lib/junit-3.8.1.jar lib/kfs-0.1.3.jar lib/log4j-1.2.13.jar lib/oro-2.0.8.jar lib/servlet-api.jar lib/slf4j-api-1.4.3.jar lib/slf4j-log4j12-1.4.3.jar lib/xmlenc-0.52.jar src/test/lib/ftplet-api-1.0.0-SNAPSHOT.jar src/test/lib/ftpserver-core-1.0.0-SNAPSHOT.jar src/test/lib/ftpserver-server-1.0.0-SNAPSHOT.jar src/test/lib/mina-core-2.0.0-M2-20080407.124109-12.jar
> {quote}
> Brice, can you rework this?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.