You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by "RekhaZemoso (via GitHub)" <gi...@apache.org> on 2023/04/14 04:04:55 UTC

[GitHub] [superset] RekhaZemoso opened a new pull request, #23688: fix:issues14985

RekhaZemoso opened a new pull request, #23688:
URL: https://github.com/apache/superset/pull/23688

   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   When we select partition chart it showing wrong information after 3rd level of partitions
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   ![Screenshot from 2023-03-21 15-36-44](https://user-images.githubusercontent.com/125271260/226576988-cb7d77d0-5ba5-4da8-9a24-37d07ad77900.png)
   ![Screenshot from 2023-03-21 15-37-16](https://user-images.githubusercontent.com/125271260/226577212-47d36873-eca5-4d2d-b3c0-53afae2bd166.png)
   
   After::
   ![Screenshot from 2023-03-21 15-37-44](https://user-images.githubusercontent.com/125271260/226577280-4da94908-d2c4-409b-8c3f-cd3d019b9486.png)
   ![Screenshot from 2023-03-21 15-38-04](https://user-images.githubusercontent.com/125271260/226577301-9144ec87-05eb-40d3-9994-e73615dba0da.png)
   
   
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue:https://github.com/apache/superset/issues/14985
   - [x] Changes UI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix: issue #14985 — partition not working after 3rd level [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.

rusackas commented on PR #23688:
URL: https://github.com/apache/superset/pull/23688#issuecomment-1936555141

   Thanks for the PR, and sorry it slid under the radar for so long. Can you give this PR a rebase, and we'll give it some review/testing if it passes CI?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix: issue #14985 — partition not working after 3rd level [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.

rusackas commented on PR #23688:
URL: https://github.com/apache/superset/pull/23688#issuecomment-1936555656

   And thank you for the contribution @RekhaZemoso!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] commented on pull request #23688: fix:issues14985

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.

codecov[bot] commented on PR #23688:
URL: https://github.com/apache/superset/pull/23688#issuecomment-1507900079

   ## [Codecov](https://codecov.io/gh/apache/superset/pull/23688?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#23688](https://codecov.io/gh/apache/superset/pull/23688?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b6d6bb8) into [master](https://codecov.io/gh/apache/superset/commit/a5c31b2426e21fc99afed5bde4151456144496af?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5c31b2) will **decrease** coverage by `10.96%`.
   > The diff coverage is `66.30%`.
   
   > :exclamation: Current head b6d6bb8 differs from pull request most recent head a90a598. Consider uploading reports for the commit a90a598 to get more accurate results
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #23688       +/-   ##
   ===========================================
   - Coverage   67.62%   56.67%   -10.96%     
   ===========================================
     Files        1908     1922       +14     
     Lines       73682    74047      +365     
     Branches     7982     8101      +119     
   ===========================================
   - Hits        49828    41965     -7863     
   - Misses      21806    30011     +8205     
   - Partials     2048     2071       +23     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `?` | |
   | postgres | `?` | |
   | presto | `53.08% <ø> (+0.42%)` | :arrow_up: |
   | python | `59.40% <ø> (-22.91%)` | :arrow_down: |
   | sqlite | `?` | |
   | unit | `53.01% <ø> (+0.49%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/23688?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...t-ui-chart-controls/src/shared-controls/mixins.tsx](https://codecov.io/gh/apache/superset/pull/23688?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3NoYXJlZC1jb250cm9scy9taXhpbnMudHN4) | `16.66% <ø> (ø)` | |
   | [...d/packages/superset-ui-chart-controls/src/types.ts](https://codecov.io/gh/apache/superset/pull/23688?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
   | [.../packages/superset-ui-core/src/chart/types/Base.ts](https://codecov.io/gh/apache/superset/pull/23688?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY2hhcnQvdHlwZXMvQmFzZS50cw==) | `100.00% <ø> (ø)` | |
   | [...s/superset-ui-core/src/components/SafeMarkdown.tsx](https://codecov.io/gh/apache/superset/pull/23688?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY29tcG9uZW50cy9TYWZlTWFya2Rvd24udHN4) | `66.66% <ø> (ø)` | |
   | [...ackages/superset-ui-core/src/query/types/Filter.ts](https://codecov.io/gh/apache/superset/pull/23688?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvcXVlcnkvdHlwZXMvRmlsdGVyLnRz) | `100.00% <ø> (ø)` | |
   | [...ackages/superset-ui-core/src/utils/featureFlags.ts](https://codecov.io/gh/apache/superset/pull/23688?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdXRpbHMvZmVhdHVyZUZsYWdzLnRz) | `100.00% <ø> (ø)` | |
   | [...plugins/legacy-plugin-chart-heatmap/src/Heatmap.js](https://codecov.io/gh/apache/superset/pull/23688?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhlYXRtYXAvc3JjL0hlYXRtYXAuanM=) | `0.00% <0.00%> (ø)` | |
   | [...gins/legacy-plugin-chart-world-map/src/WorldMap.js](https://codecov.io/gh/apache/superset/pull/23688?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXdvcmxkLW1hcC9zcmMvV29ybGRNYXAuanM=) | `0.00% <0.00%> (ø)` | |
   | [...plugins/legacy-plugin-chart-world-map/src/index.js](https://codecov.io/gh/apache/superset/pull/23688?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXdvcmxkLW1hcC9zcmMvaW5kZXguanM=) | `66.66% <ø> (ø)` | |
   | [...tend/plugins/legacy-preset-chart-nvd3/src/utils.js](https://codecov.io/gh/apache/superset/pull/23688?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LW52ZDMvc3JjL3V0aWxzLmpz) | `15.92% <ø> (ø)` | |
   | ... and [189 more](https://codecov.io/gh/apache/superset/pull/23688?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ... and [400 files with indirect coverage changes](https://codecov.io/gh/apache/superset/pull/23688/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org