You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "shoothzj (via GitHub)" <gi...@apache.org> on 2024/04/23 01:08:12 UTC
[PR] build: disable BookieZKExpireTest beyond jdk17 [bookkeeper]
shoothzj opened a new pull request, #4309:
URL: https://github.com/apache/bookkeeper/pull/4309
### Motivation
As of JDK 21, the methods `suspend` and `resume` on the `Thread` class throw `UnsupportedOperationException`.
### Changes
1. Added junit5 annotation `@EnabledForJreRange(max = JRE.JAVA_17)`(It's modern and better than junit4) to tests that use `suspend` and `resume`, effectively disabling these tests on JDK versions higher than 17 where these methods are not supported.
2. Migrate this test file to junit5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build: disable BookieZKExpireTest beyond jdk17 [bookkeeper]
Posted by "shoothzj (via GitHub)" <gi...@apache.org>.
shoothzj commented on PR #4309:
URL: https://github.com/apache/bookkeeper/pull/4309#issuecomment-2076049456
@dlg99 @eolivelli @hangc0276 @merlimat @nicoloboschi @zhaijack PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build: disable BookieZKExpireTest beyond jdk17 [bookkeeper]
Posted by "shoothzj (via GitHub)" <gi...@apache.org>.
shoothzj merged PR #4309:
URL: https://github.com/apache/bookkeeper/pull/4309
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build: disable BookieZKExpireTest beyond jdk17 [bookkeeper]
Posted by "shoothzj (via GitHub)" <gi...@apache.org>.
shoothzj commented on PR #4309:
URL: https://github.com/apache/bookkeeper/pull/4309#issuecomment-2071233994
@dlg99 @eolivelli @hangc0276 @merlimat @nicoloboschi @zhaijack PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org