[GitHub] [apisix-helm-chart] tao12345666333 commented on a change in pull request #106: Update etcd and dashboard

[GitBox <gi...@apache.org>]

tao12345666333 commented on a change in pull request #106:
URL: https://github.com/apache/apisix-helm-chart/pull/106#discussion_r658443448



##########
File path: charts/apisix/values.yaml
##########
@@ -211,12 +211,21 @@ etcd:
   service:
     port: 2379
 
-  replicaCount: 3
+  statefulset:
+    replicaCount: 3
 
+  persistence:
+    enabled: true
+    size: 8Gi
+    # storageClass: "-"
 
 dashboard:
   enabled: false
-
+  config:

Review comment:
       We currently have two main usage scenarios
   
   * `helm install apisix apisix/apisix --set dashboard.enabled=true`  install apisix and apisix-dashboard.
   * `helm install dashboard apisix/apisix-dashboard` only install apisix-dashboard.
   
   In fact, here we use the subchart method for quoting, just make sure that the configuration here is consistent with the configuration in subchart.
   
   But as we hope, we hope to reduce repeat works.
   Let me have a quick try and give you an answer later




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org