You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by ppadma <gi...@git.apache.org> on 2018/02/06 21:30:18 UTC
[GitHub] drill pull request #1115: DRILL-6138: Move RecordBatchSizer to org.apache.dr...
GitHub user ppadma opened a pull request:
https://github.com/apache/drill/pull/1115
DRILL-6138: Move RecordBatchSizer to org.apache.drill.exec.record pac…
…kage
Also, changed columnSizes in RecordBatchSizer from list to map so we can lookup using field names.
@Ben-Zvi can you please review ?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ppadma/drill DRILL-6138
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/1115.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1115
----
commit b4104e73ad37dee96e29e345b958412791ab9079
Author: Padma Penumarthy <pp...@...>
Date: 2018-02-06T05:41:45Z
DRILL-6138: Move RecordBatchSizer to org.apache.drill.exec.record package
----
---
[GitHub] drill pull request #1115: DRILL-6138: Move RecordBatchSizer to org.apache.dr...
Posted by Ben-Zvi <gi...@git.apache.org>.
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/1115#discussion_r166454887
--- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchSizer.java ---
@@ -260,7 +254,7 @@ public static ColumnSize getColumn(ValueVector v, String prefix) {
public static final int MAX_VECTOR_SIZE = ValueVector.MAX_BUFFER_SIZE; // 16 MiB
- private List<ColumnSize> columnSizes = new ArrayList<>();
+ private Map<String, ColumnSize> columnSizes = CaseInsensitiveMap.newHashMap();
--- End diff --
Tim (@ilooner) made the same change for DRILL-6032 ( #1101 )
---
[GitHub] drill pull request #1115: DRILL-6138: Move RecordBatchSizer to org.apache.dr...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1115
---
[GitHub] drill pull request #1115: DRILL-6138: Move RecordBatchSizer to org.apache.dr...
Posted by ilooner <gi...@git.apache.org>.
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/1115#discussion_r166459971
--- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchSizer.java ---
@@ -260,7 +254,7 @@ public static ColumnSize getColumn(ValueVector v, String prefix) {
public static final int MAX_VECTOR_SIZE = ValueVector.MAX_BUFFER_SIZE; // 16 MiB
- private List<ColumnSize> columnSizes = new ArrayList<>();
+ private Map<String, ColumnSize> columnSizes = CaseInsensitiveMap.newHashMap();
--- End diff --
I'll rebase after this change goes in.
---