You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/10/24 16:35:20 UTC
[GitHub] [iceberg] nastra opened a new pull request, #6037: API,Core: Move ScanReport to core module / extract TimerResult/CounterResult/ScanMetricsResult into own classes
nastra opened a new pull request, #6037:
URL: https://github.com/apache/iceberg/pull/6037
The motivation behind moving `ScanReport` to `iceberg-core` is because we don't actually need it in the `iceberg-api`, since `MetricsReporter` only requires to have `MetricsReport` in the `iceberg-api` module.
The motivation for extracting all of those classes out of `ScanReport` is so that we can reuse them in order to introduce an `IncrementalScanReport` class, which slightly differs from `ScanReport` around the snapshot (since it requires from/to snapshot IDs)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #6037: API,Core: Move ScanReport to core module / extract TimerResult/CounterResult/ScanMetricsResult into own classes
Posted by GitBox <gi...@apache.org>.
rdblue commented on PR #6037:
URL: https://github.com/apache/iceberg/pull/6037#issuecomment-1289304312
Looks good to me. I like not having so many nested interfaces!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #6037: API,Core: Move ScanReport to core module / extract TimerResult/CounterResult/ScanMetricsResult into own classes
Posted by GitBox <gi...@apache.org>.
rdblue merged PR #6037:
URL: https://github.com/apache/iceberg/pull/6037
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org