You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by rajinisivaram <gi...@git.apache.org> on 2017/06/06 14:10:12 UTC

[GitHub] kafka pull request #3246: KAFKA-4948: Wait for offset commit in test to fix ...

GitHub user rajinisivaram opened a pull request:

    https://github.com/apache/kafka/pull/3246

    KAFKA-4948: Wait for offset commit in test to fix transient failure

    `DescribeConsumerGroupTest#testDescribeExistingGroupWithNoMembersWithNewConsumer` shuts down the consumer executor thread and then checks that the assignments returned by `describeGroup` contain the consume group with no members. But if the executor thread is shut down before any offsets are committed, the assignments returned by `describeGroup` doesn't contain the group at all. This PR waits for an offset commit by waiting for the group to appear in `describeGroup` assignments prior to shutting down the executor.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rajinisivaram/kafka KAFKA-4948

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3246.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3246
    
----
commit cda6b607e83078f5941731b73d7c38575606d473
Author: Rajini Sivaram <ra...@googlemail.com>
Date:   2017-06-06T13:28:16Z

    KAFKA-4948: Wait for offset commit in test to fix transient failure

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3246: KAFKA-4948: Wait for offset commit in test to fix ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/3246


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---