[GitHub] [spark] HyukjinKwon commented on a diff in pull request #40292: [SPARK-42676][SS] Write temp checkpoints for streaming queries to local filesystem even if default FS is set differently

["HyukjinKwon (via GitHub)" <gi...@apache.org>]

HyukjinKwon commented on code in PR #40292:
URL: https://github.com/apache/spark/pull/40292#discussion_r1188090201


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/ResolveWriteToStream.scala:
##########
@@ -81,7 +81,9 @@ object ResolveWriteToStream extends Rule[LogicalPlan] with SQLConfHelper {
           s" the query didn't fail: $tempDir. If it's required to delete it under any" +
           s" circumstances, please set ${SQLConf.FORCE_DELETE_TEMP_CHECKPOINT_LOCATION.key} to" +
           s" true. Important to know deleting temp checkpoint folder is best effort.")
-        tempDir
+        // SPARK-42676 - Write temp checkpoints for streaming queries to local filesystem
+        // even if default FS is set differently
+        "file://" + tempDir

Review Comment:
   This actually broke the Windows support (https://ci.appveyor.com/project/ApacheSoftwareFoundation/spark/builds/46451196). Canonical paths are actually not necessarily a URI too - it might contain white spaces as an example.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org