You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2022/05/28 10:18:16 UTC
[GitHub] [jena] afs opened a new pull request, #1343: GH-1272: Use static in-scope base for IRI()
afs opened a new pull request, #1343:
URL: https://github.com/apache/jena/pull/1343
Static scoped base for IRI("<x>").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs merged pull request #1343: GH-1272: Use static in-scope base for IRI()
Posted by GitBox <gi...@apache.org>.
afs merged PR #1343:
URL: https://github.com/apache/jena/pull/1343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on pull request #1343: GH-1272: Use static in-scope base for IRI()
Posted by GitBox <gi...@apache.org>.
afs commented on PR #1343:
URL: https://github.com/apache/jena/pull/1343#issuecomment-1142551419
There are now 2 IRI functions: the standard "E_IRI" takes on argument and records the pasrer base and "E_IRI2" which has two arguments - `(base, rel)` - and because `base` can be relative, it also records the parser base.
These become functions `(iri)` and `(iri2)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on pull request #1343: GH-1272: Use static in-scope base for IRI()
Posted by GitBox <gi...@apache.org>.
afs commented on PR #1343:
URL: https://github.com/apache/jena/pull/1343#issuecomment-1140449274
> Just a minor remark: E_IRI should have a public getBase() method
yes, and more! The second commit add a 2-argument form `IRI(baseExpr, rel)`. For update, I think that this general form might be useful for translating data. Experimental.
That'll need accessors to the state of E_IRI that "ExprFunction1" does not expose for printing (to SSE and to SPARQL) - WIP.
Whether it is better to be an "ExprFunction2" or "ExprFunctionN" isn't clear. `IRI` is still primarily a one-argument function. because it retains how it was setup (implicit base or explicit base), it isn't a true "ExprFunction2" either.
(And some of this code structure is really old!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] Aklakan commented on pull request #1343: GH-1272: Use static in-scope base for IRI()
Posted by GitBox <gi...@apache.org>.
Aklakan commented on PR #1343:
URL: https://github.com/apache/jena/pull/1343#issuecomment-1140445468
Just a minor remark: E_URI should have a public getBase() method so it can be accessed during expression traversal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on pull request #1343: GH-1272: Use static in-scope base for IRI()
Posted by GitBox <gi...@apache.org>.
afs commented on PR #1343:
URL: https://github.com/apache/jena/pull/1343#issuecomment-1140231213
There is one wrinkle to sort out. SSE parsers in two steps: text to general expression and general expression to update.
There is compatibility code in the PR.
Ideally, `(iri ...)` would take a new, optional arg to be the base. That said, SSE+updates isn't very common and SSE is primarily for Jena-dev use, it's just grown / been spotted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org