You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2016/02/24 22:44:18 UTC

[lang] Statement unnecessarily nested within else clause.

Repository: commons-lang
Updated Branches:
  refs/heads/master ddcf6aa50 -> 63374a181


Statement unnecessarily nested within else clause.

Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/63374a18
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/63374a18
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/63374a18

Branch: refs/heads/master
Commit: 63374a181393d941c805b6909c2ae5c41159e745
Parents: ddcf6aa
Author: ggregory <gg...@apache.org>
Authored: Wed Feb 24 13:44:16 2016 -0800
Committer: ggregory <gg...@apache.org>
Committed: Wed Feb 24 13:44:16 2016 -0800

----------------------------------------------------------------------
 .../apache/commons/lang3/math/NumberUtils.java    | 18 +++---------------
 1 file changed, 3 insertions(+), 15 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-lang/blob/63374a18/src/main/java/org/apache/commons/lang3/math/NumberUtils.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/lang3/math/NumberUtils.java b/src/main/java/org/apache/commons/lang3/math/NumberUtils.java
index 3ca1d3e..ead5277 100644
--- a/src/main/java/org/apache/commons/lang3/math/NumberUtils.java
+++ b/src/main/java/org/apache/commons/lang3/math/NumberUtils.java
@@ -1527,11 +1527,7 @@ public class NumberUtils {
         if (x == y) {
             return 0;
         }
-        if (x < y) {
-            return -1;
-        } else {
-            return 1;
-        }
+        return x < y ? -1 : 1;
     }
 
     /**
@@ -1548,11 +1544,7 @@ public class NumberUtils {
         if (x == y) {
             return 0;
         }
-        if (x < y) {
-            return -1;
-        } else {
-            return 1;
-        }
+        return x < y ? -1 : 1;
     }
 
     /**
@@ -1569,11 +1561,7 @@ public class NumberUtils {
         if (x == y) {
             return 0;
         }
-        if (x < y) {
-            return -1;
-        } else {
-            return 1;
-        }
+        return x < y ? -1 : 1;
     }
 
     /**