You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by ce...@apache.org on 2015/10/05 08:41:48 UTC
svn commit: r1706750 - in /poi/trunk/src:
scratchpad/src/org/apache/poi/hwpf/model/PlexOfCps.java
testcases/org/apache/poi/hssf/usermodel/TestHSSFHyperlink.java
Author: centic
Date: Mon Oct 5 06:41:48 2015
New Revision: 1706750
URL: http://svn.apache.org/viewvc?rev=1706750&view=rev
Log:
Eclipse warnings
Modified:
poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/model/PlexOfCps.java
poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFHyperlink.java
Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/model/PlexOfCps.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/model/PlexOfCps.java?rev=1706750&r1=1706749&r2=1706750&view=diff
==============================================================================
--- poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/model/PlexOfCps.java (original)
+++ poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/model/PlexOfCps.java Mon Oct 5 06:41:48 2015
@@ -18,6 +18,7 @@
package org.apache.poi.hwpf.model;
import java.util.ArrayList;
+import java.util.List;
import org.apache.poi.util.Internal;
import org.apache.poi.util.LittleEndian;
@@ -37,7 +38,7 @@ public final class PlexOfCps
private int _iMac;
private int _offset;
private int _cbStruct;
- private ArrayList<GenericPropertyNode> _props;
+ private List<GenericPropertyNode> _props;
public PlexOfCps( int sizeOfStruct )
{
Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFHyperlink.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFHyperlink.java?rev=1706750&r1=1706749&r2=1706750&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFHyperlink.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFHyperlink.java Mon Oct 5 06:41:48 2015
@@ -17,8 +17,10 @@
package org.apache.poi.hssf.usermodel;
-import org.apache.poi.hssf.HSSFTestDataSamples;
+import java.io.IOException;
+
import org.apache.poi.hssf.HSSFITestDataProvider;
+import org.apache.poi.hssf.HSSFTestDataSamples;
import org.apache.poi.ss.usermodel.BaseTestHyperlink;
/**
@@ -107,8 +109,9 @@ public final class TestHSSFHyperlink ext
* link.setTextMark("'Target Sheet-1'!A1"); //HSSF-specific
* or
* link.setAddress("'Target Sheet-1'!A1"); //common between XSSF and HSSF
+ * @throws IOException
*/
- public void testCreateDocumentLink() {
+ public void testCreateDocumentLink() throws IOException {
HSSFWorkbook wb = new HSSFWorkbook();
//link to a place in this workbook
@@ -134,8 +137,10 @@ public final class TestHSSFHyperlink ext
link.setAddress("'Hyperlinks'!A1");
cell.setHyperlink(link);
- wb = HSSFTestDataSamples.writeOutAndReadBack(wb);
- sheet = wb.getSheet("Hyperlinks");
+ HSSFWorkbook wbBack = HSSFTestDataSamples.writeOutAndReadBack(wb);
+ wb.close();
+
+ sheet = wbBack.getSheet("Hyperlinks");
cell = sheet.getRow(0).getCell(0);
link = cell.getHyperlink();
@@ -148,6 +153,8 @@ public final class TestHSSFHyperlink ext
assertNotNull(link);
assertEquals("'Hyperlinks'!A1", link.getTextMark());
assertEquals("'Hyperlinks'!A1", link.getAddress());
+
+ wbBack.close();
}
public void testCloneSheet() {
@@ -169,7 +176,7 @@ public final class TestHSSFHyperlink ext
assertEquals("http://poi.apache.org/hssf/", link.getAddress());
}
- public void testCreate() {
+ public void testCreate() throws IOException {
HSSFWorkbook wb = new HSSFWorkbook();
HSSFHyperlink link;
@@ -182,13 +189,18 @@ public final class TestHSSFHyperlink ext
link.setAddress("testfolder\\test.PDF");
cell.setHyperlink(link);
- wb = HSSFTestDataSamples.writeOutAndReadBack(wb);
- sheet = wb.getSheet("Hyperlinks");
+ HSSFWorkbook wbBack = HSSFTestDataSamples.writeOutAndReadBack(wb);
+
+ wb.close();
+
+ sheet = wbBack.getSheet("Hyperlinks");
cell = sheet.getRow(1).getCell(0);
link = cell.getHyperlink();
assertNotNull(link);
assertEquals("testfolder\\test.PDF", link.getAddress());
+
+ wbBack.close();
}
/**
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org