You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/01/02 06:40:29 UTC

[GitHub] [incubator-seatunnel] leo65535 commented on a change in pull request #906: [SeaTunnel #904] [config] improve the config parse logic

leo65535 commented on a change in pull request #906:
URL: https://github.com/apache/incubator-seatunnel/pull/906#discussion_r777171975



##########
File path: seatunnel-config/src/test/java/org/apache/seatunnel/config/CompleteTests.java
##########
@@ -17,35 +17,23 @@
 
 package org.apache.seatunnel.config;
 
-import java.io.File;
-import java.net.URL;
+import com.typesafe.config.Config;
+import com.typesafe.config.ConfigRenderOptions;
+import com.typesafe.config.ConfigResolveOptions;
+import com.typesafe.config.SeaTunnelConfigFactory;
+import org.apache.seatunnel.config.utils.FileUtils;
 
 public class CompleteTests {
 
     public static void main(String[] args) {

Review comment:
       There is a bug between `dev` and `1faf2e`.
   
   https://github.com/apache/incubator-seatunnel/issues/924




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org