You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/01/05 07:26:58 UTC

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #551: make/archive: replace the dependency to preprequisite list

xiaoxiang781216 commented on a change in pull request #551:
URL: https://github.com/apache/incubator-nuttx-apps/pull/551#discussion_r551757718



##########
File path: Application.mk
##########
@@ -138,11 +138,11 @@ $(CXXOBJS): %$(SUFFIX)$(OBJEXT): %$(CXXEXT)
 	$(if $(and $(CONFIG_BUILD_LOADABLE),$(CXXELFFLAGS)), \
 		$(call ELFCOMPILEXX, $<, $@), $(call COMPILEXX, $<, $@))
 
-archive:
+archive: $(OBJS)

Review comment:
       should we chnage archive to a real target? then we can avoid the achive every time even there is nothing to change.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org