You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/08/22 00:16:15 UTC
[GitHub] [trafficcontrol] jhg03a opened a new issue #4984: Postinstall can no longer be run twice
jhg03a opened a new issue #4984:
URL: https://github.com/apache/trafficcontrol/issues/4984
<!--
************ STOP!! ************
If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact
the Apache Software Foundation Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
- For *SUPPORT QUESTIONS*, use the
[Traffic Control slack channels](https://traffic-control-cdn.slack.com) or [Traffic Control mailing lists](http://trafficcontrol.apache.org/mailing_lists/).
- Before submitting, please **SEARCH GITHUB** for a similar issue or PR. -->
## I'm submitting a ...
<!-- delete all those that don't apply -->
<!--- security vulnerability (STOP!! - see above)-->
- bug report
## Traffic Control components affected ...
<!-- delete all those that don't apply -->
- Traffic Ops
## Current behavior:
<!-- Describe how the bug manifests / how the current features are insufficient. -->
Running postinstall.pl twice causes failure.
## Expected / new behavior:
<!-- Describe what the behavior would be without the bug / how the feature would improve Traffic Control -->
Previously there hadn't been issues with running Postinstall twice
## Minimal reproduction of the problem with instructions:
<!--
If the current behavior is a bug or you can illustrate your feature request better with an example,
please provide the *STEPS TO REPRODUCE* and include the applicable TC version.
-->
1. Run Postinstall
2. Run Postinstall again with the same input
## Anything else:
<!-- e.g. stacktraces, related issues, suggestions how to fix -->
ERROR: function on_update_current_timestamp_last_updated already exists with same argument types
Can't create database tables
Died at /opt/traffic_ops/install/lib/InstallUtils.pm line 62.
Database load_schema failed
Error on line 57 of /opt/traffic_ops/install/bin/postinstall
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on issue #4984: Postinstall can no longer be run twice
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on issue #4984:
URL: https://github.com/apache/trafficcontrol/issues/4984#issuecomment-703998580
Spoke to @jhg03a, got a longer log of the failure:
```sql
Creating database tables.
/*
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
SET statement_timeout = 0;
SET
SET lock_timeout = 0;
SET
SET client_encoding = 'UTF8';
SET
SET standard_conforming_strings = on;
SET
SET check_function_bodies = false;
SET
SET client_min_messages = warning;
SET
SET row_security = off;
SET
CREATE EXTENSION IF NOT EXISTS plpgsql WITH SCHEMA pg_catalog;
CREATE EXTENSION
SET search_path = public, pg_catalog;
SET
CREATE FUNCTION on_update_current_timestamp_last_updated() RETURNS trigger
LANGUAGE plpgsql
AS $$
BEGIN
NEW.last_updated = now();
RETURN NEW;
END;
$$;
ERROR: function "on_update_current_timestamp_last_updated" already exists with same argument types
Can't create database tables
Died at /opt/traffic_ops/install/lib/InstallUtils.pm line 62.
Database load_schema failed
Error on line 57 of /opt/traffic_ops/install/bin/postinstall"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp closed issue #4984: Postinstall can no longer be run twice
Posted by GitBox <gi...@apache.org>.
rawlinp closed issue #4984:
URL: https://github.com/apache/trafficcontrol/issues/4984
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on issue #4984: Postinstall can no longer be run twice
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on issue #4984:
URL: https://github.com/apache/trafficcontrol/issues/4984#issuecomment-703945927
@jhg03a Are you still able to reproduce this? I am able to run Postinstall twice without issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on issue #4984: Postinstall can no longer be run twice
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on issue #4984:
URL: https://github.com/apache/trafficcontrol/issues/4984#issuecomment-708574022
Changed from [regression bug](https://github.com/apache/trafficcontrol/labels/regression%20bug) to [bug](https://github.com/apache/trafficcontrol/labels/bug). Postinstall can be run twice, what does not work is running it twice concurrently, since it is not marked as having run until Postinstall completes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] jhg03a commented on issue #4984: Postinstall can no longer be run twice
Posted by GitBox <gi...@apache.org>.
jhg03a commented on issue #4984:
URL: https://github.com/apache/trafficcontrol/issues/4984#issuecomment-678566861
This also breaks installing TO on more than one host.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org