You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/04/06 12:33:28 UTC

[GitHub] [kafka] dengziming opened a new pull request #10488: MINOR: Remove some unnecessary cyclomatic complexity suppressions

dengziming opened a new pull request #10488:
URL: https://github.com/apache/kafka/pull/10488


   *More detailed description of your change*
   I find these classes don't violate cyclomatic complexity.
   
   *Summary of testing strategy (including rationale)*
   QA
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 merged pull request #10488: MINOR: Remove some unnecessary cyclomatic complexity suppressions

Posted by GitBox <gi...@apache.org>.
chia7712 merged pull request #10488:
URL: https://github.com/apache/kafka/pull/10488


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dengziming commented on pull request #10488: MINOR: Remove some unnecessary cyclomatic complexity suppressions

Posted by GitBox <gi...@apache.org>.
dengziming commented on pull request #10488:
URL: https://github.com/apache/kafka/pull/10488#issuecomment-816368204


   @chia7712 , Hello, PTAL, Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dengziming commented on pull request #10488: MINOR: Remove some unnecessary cyclomatic complexity suppressions

Posted by GitBox <gi...@apache.org>.
dengziming commented on pull request #10488:
URL: https://github.com/apache/kafka/pull/10488#issuecomment-817660577


   ```
   Test Result (10 failures / +3)
   Build / JDK 15 and Scala 2.13 / org.apache.kafka.streams.integration.EOSUncleanShutdownIntegrationTest.shouldWorkWithUncleanShutdownWipeOutStateStore[exactly_once_beta]
   Build / JDK 15 and Scala 2.13 / org.apache.kafka.streams.integration.KTableKTableForeignKeyInnerJoinMultiIntegrationTest.shouldInnerJoinMultiPartitionQueryable
   Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest.testOneWayReplicationWithAutoOffsetSync()
   Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationTest.testOneWayReplicationWithAutoOffsetSync()
   Build / JDK 15 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest.testReplication()
   Build / JDK 15 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest.testReplicationWithEmptyPartition()
   Build / JDK 15 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest.testOneWayReplicationWithAutoOffsetSync()
   Build / JDK 15 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationTest.testReplication()
   Build / JDK 15 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationTest.testReplicationWithEmptyPartition()
   Build / JDK 15 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationTest.testOneWayReplicationWithAutoOffsetSync()
   ```
   these test failures from `stream` and `connect` are unrelated flaky tests, @chia7712 .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 commented on pull request #10488: MINOR: Remove some unnecessary cyclomatic complexity suppressions

Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #10488:
URL: https://github.com/apache/kafka/pull/10488#issuecomment-817499047


   @dengziming Could you trigger QA again? thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 commented on pull request #10488: MINOR: Remove some unnecessary cyclomatic complexity suppressions

Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #10488:
URL: https://github.com/apache/kafka/pull/10488#issuecomment-817664418


   @dengziming thanks for your patch :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org