You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/02/13 18:39:31 UTC

[GitHub] rumbin commented on issue #4413: Remove comments from queries in SQL Lab that break Explore view

rumbin commented on issue #4413: Remove comments from queries in SQL Lab that break Explore view
URL: https://github.com/apache/incubator-superset/pull/4413#issuecomment-365362266
 
 
   Will this strip the comments when transferring to a table definition, or will they still exist right there but stripped when the table is queried on?
   
   In the first case, I feel this would be an unexpected behavior. The user may have good reasons for commenting their code, e.g., _why_ was something included or excluded in the query.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services